-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain to mesh #151
Domain to mesh #151
Conversation
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
src/mesh/domain.jl
Outdated
@@ -16,6 +16,10 @@ abstract type AbstractCellDomain{M, I} <: AbstractDomain{M} end | |||
A `CellDomain` is a representation of the cells of a mesh. It's primary | |||
purpose is to represent a domain to integrate over. | |||
|
|||
# Constructors | |||
CellDomain(mesh::Mesh) | |||
CellDomain(mesh::Mesh, f::Function, all_nodes = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to create a specific function like identify_cell_indices(f, all_nodes = true)
which returns the cell indices of cells whose vertices (or at least one vertex) verify f(x)==true
as it could be relevant for other purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've named it identify_cells
, is it ok for you?
@test ncells(new_mesh) == 3 | ||
@test Bcube.inner_faces(new_mesh) == [3, 6] | ||
@test Bcube.outer_faces(new_mesh) == [1, 2, 4, 5, 7, 8, 9, 10] | ||
@test Bcube.boundary_faces(new_mesh, "CLIPPED_BND") == [1, 4, 5] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be one test for original boundary face tags would be great to have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the new version if it corresponds to what you asked for
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Bcube.jl/Bcube.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
A bit ugly, but seems to work!