-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gmsh mesh generators #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am setting it as a draft cause I will add some tests (with the sha1 procedure). |
ghislainb
reviewed
Nov 19, 2023
ghislainb
previously approved these changes
Nov 19, 2023
ghislainb
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored a bit the gmsh mesh generators (we could go even further);
I have removed all dependencies of
test
toinput/mesh
: I've converted all the gmsh input file intogmsh_utils.jl
functions that generate the equivalent meshes. Once the BcubeTutorial repo will be available, there will be no moreinput
folder. For_gen_2cubes_mesh
and_gen_pile_mesh
, we could directly create theMesh
manually, but having the gmsh script enable the possibility to easily complexify the mesh. @ghislainb what do you think?In the
test
, I systematically create a new gmsh mesh when needed. @ghislainb : would you prefer that we create all the mesh once and for all in theruntests.jl
file and provide a list of path to the included files? That will save some time, but it will be a bit less flexible at lower levelI have updated the readme.md to fix the gallery issue;
some minor functions signature modifications to improve compatibility with BcubeParallel.