Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gmsh mesh generators #3

Merged
merged 14 commits into from
Nov 20, 2023
Merged

Refactor gmsh mesh generators #3

merged 14 commits into from
Nov 20, 2023

Conversation

bmxam
Copy link
Member

@bmxam bmxam commented Nov 18, 2023

  • I have refactored a bit the gmsh mesh generators (we could go even further);

  • I have removed all dependencies of test to input/mesh : I've converted all the gmsh input file into gmsh_utils.jl functions that generate the equivalent meshes. Once the BcubeTutorial repo will be available, there will be no more input folder. For _gen_2cubes_mesh and _gen_pile_mesh, we could directly create the Mesh manually, but having the gmsh script enable the possibility to easily complexify the mesh. @ghislainb what do you think?

  • In the test, I systematically create a new gmsh mesh when needed. @ghislainb : would you prefer that we create all the mesh once and for all in the runtests.jl file and provide a list of path to the included files? That will save some time, but it will be a bit less flexible at lower level

  • I have updated the readme.md to fix the gallery issue;

  • some minor functions signature modifications to improve compatibility with BcubeParallel.

@bmxam bmxam requested a review from ghislainb November 18, 2023 21:22
@bmxam bmxam added the draft label Nov 18, 2023
@bmxam
Copy link
Member Author

bmxam commented Nov 18, 2023

I am setting it as a draft cause I will add some tests (with the sha1 procedure).

@bmxam bmxam removed the draft label Nov 19, 2023
ghislainb
ghislainb previously approved these changes Nov 19, 2023
@bmxam bmxam merged commit 12e4890 into main Nov 20, 2023
5 checks passed
@bmxam bmxam deleted the dev_gmsh branch November 20, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants