Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new LazyBinaryOperator pow #32

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add new LazyBinaryOperator pow #32

merged 1 commit into from
Dec 19, 2023

Conversation

ghislainb
Copy link
Member

No description provided.

@ghislainb ghislainb requested a review from bmxam December 18, 2023 15:27
@ghislainb ghislainb linked an issue Dec 18, 2023 that may be closed by this pull request
Copy link

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

  • Time of benchmarks:
    • Target: 18 Dec 2023 - 15:34
    • Baseline: 18 Dec 2023 - 15:36
  • Package commits:
    • Target: d75cd5
    • Baseline: 8cf388
  • Julia commits:
    • Target: 17cfb8
    • Baseline: 17cfb8
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["entities", "edges2nodes"] 0.63 (5%) ✅ 1.00 (1%)
["entities", "nedges"] 0.63 (5%) ✅ 1.00 (1%)
["entities", "nnodes"] 0.77 (5%) ✅ 1.00 (1%)
["entities", "nodes"] 0.63 (5%) ✅ 1.00 (1%)
["mesh", "todo"] 0.63 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["covo", "Quad"]
  • ["covo", "TriQuad"]
  • ["entities"]
  • ["mesh"]

Julia versioninfo

Target

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       1493 s          0 s        189 s       2824 s          0 s
       #2  3244 MHz       1197 s          0 s        174 s       3141 s          0 s
       #3  2593 MHz       1477 s          0 s        178 s       2846 s          0 s
       #4  2572 MHz       1699 s          0 s        208 s       2601 s          0 s
  Memory: 15.60690689086914 GB (12901.03125 MB free)
  Uptime: 453.72 sec
  Load Avg:  1.23  1.26  0.67
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2594 MHz       1914 s          0 s        219 s       3853 s          0 s
       #2  2445 MHz       1527 s          0 s        226 s       4239 s          0 s
       #3  3271 MHz       2000 s          0 s        226 s       3756 s          0 s
       #4  3242 MHz       1804 s          0 s        225 s       3959 s          0 s
  Memory: 15.60690689086914 GB (12833.67578125 MB free)
  Uptime: 602.0 sec
  Load Avg:  1.02  1.15  0.73
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Target result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

  • Time of benchmark: 18 Dec 2023 - 15:34
  • Package commit: d75cd5
  • Julia commit: 17cfb8
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["covo", "Quad", "explicit_step"] 97.278 ms (5%) 69.30 MiB (1%) 3491
["covo", "Quad", "integral_surface"] 44.522 ms (5%)
["covo", "Quad", "integral_volume"] 22.346 ms (5%)
["covo", "TriQuad", "explicit_step"] 345.261 ms (5%) 18.585 ms 364.69 MiB (1%) 1634503
["covo", "TriQuad", "integral_surface"] 224.708 ms (5%) 210.06 MiB (1%) 1246116
["covo", "TriQuad", "integral_volume"] 54.851 ms (5%) 48.39 MiB (1%) 379526
["entities", "edges2nodes"] 1.552 ns (5%)
["entities", "nedges"] 1.552 ns (5%)
["entities", "nnodes"] 3.095 ns (5%)
["entities", "nodes"] 1.552 ns (5%)
["mesh", "todo"] 1.552 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["covo", "Quad"]
  • ["covo", "TriQuad"]
  • ["entities"]
  • ["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       1493 s          0 s        189 s       2824 s          0 s
       #2  3244 MHz       1197 s          0 s        174 s       3141 s          0 s
       #3  2593 MHz       1477 s          0 s        178 s       2846 s          0 s
       #4  2572 MHz       1699 s          0 s        208 s       2601 s          0 s
  Memory: 15.60690689086914 GB (12901.03125 MB free)
  Uptime: 453.72 sec
  Load Avg:  1.23  1.26  0.67
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

  • Time of benchmark: 18 Dec 2023 - 15:36
  • Package commit: 8cf388
  • Julia commit: 17cfb8
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["covo", "Quad", "explicit_step"] 96.819 ms (5%) 69.30 MiB (1%) 3491
["covo", "Quad", "integral_surface"] 46.350 ms (5%)
["covo", "Quad", "integral_volume"] 22.266 ms (5%)
["covo", "TriQuad", "explicit_step"] 350.013 ms (5%) 18.628 ms 364.69 MiB (1%) 1634503
["covo", "TriQuad", "integral_surface"] 224.727 ms (5%) 210.06 MiB (1%) 1246116
["covo", "TriQuad", "integral_volume"] 54.894 ms (5%) 48.39 MiB (1%) 379526
["entities", "edges2nodes"] 2.464 ns (5%)
["entities", "nedges"] 2.464 ns (5%)
["entities", "nnodes"] 4.007 ns (5%)
["entities", "nodes"] 2.464 ns (5%)
["mesh", "todo"] 2.464 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["covo", "Quad"]
  • ["covo", "TriQuad"]
  • ["entities"]
  • ["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2594 MHz       1914 s          0 s        219 s       3853 s          0 s
       #2  2445 MHz       1527 s          0 s        226 s       4239 s          0 s
       #3  3271 MHz       2000 s          0 s        226 s       3756 s          0 s
       #4  3242 MHz       1804 s          0 s        225 s       3959 s          0 s
  Memory: 15.60690689086914 GB (12833.67578125 MB free)
  Uptime: 602.0 sec
  Load Avg:  1.02  1.15  0.73
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 4

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           1
BogoMIPS:                           4890.86
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                     AMD-V
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           1 MiB (2 instances)
L3 cache:                           32 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Copy link

Benchmark Results

main a294ee1... t[main]/t[a294ee1...]
covo/Quad/explicit_step 0.0958 ± 0.0035 s 0.0974 ± 0.0035 s 0.984
covo/Quad/integral_surface 0.0471 ± 0.00022 s 0.0476 ± 0.00016 s 0.99
covo/Quad/integral_volume 22.6 ± 0.041 ms 22.5 ± 0.04 ms 1
covo/TriQuad/explicit_step 0.382 ± 0.03 s 0.378 ± 0.029 s 1.01
covo/TriQuad/integral_surface 0.253 ± 0.0023 s 0.252 ± 0.0036 s 1
covo/TriQuad/integral_volume 0.0703 ± 0.0033 s 0.0694 ± 0.0028 s 1.01
entities/edges2nodes 1.56 ± 0.01 ns 1.55 ± 0.01 ns 1.01
entities/nedges 1.56 ± 0.01 ns 1.55 ± 0.01 ns 1.01
entities/nnodes 3.1 ± 0.01 ns 2.79 ± 0.009 ns 1.11
entities/nodes 1.55 ± 0.01 ns 1.55 ± 0.01 ns 1
mesh/todo 1.55 ± 0.01 ns 1.55 ± 0.01 ns 1
time_to_load 14.3 ± 0.042 s 14.3 ± 0.01 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@@ -65,6 +66,13 @@ Base.:/(a, ::NullOperator) = error("Division by an AbstractNullOperator is not a
Base.:/(a::NullOperator, b) = a
Base.:/(::NullOperator, ::NullOperator) = NullOperator()

# For binary `^`:
Base.:^(a, ::NullOperator) = error("Undefined")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why defining a method that returns error rather than not defining anything and let julia raise an error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if we don't raise an error explicitly we will forget that the method was not defined on purpose.

@ghislainb ghislainb requested a review from bmxam December 19, 2023 14:17
@ghislainb ghislainb merged commit 8e8d596 into main Dec 19, 2023
8 checks passed
@ghislainb ghislainb deleted the lazyop_pow branch December 19, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pow of a LazyOp
2 participants