Addition of multiplierFESpace #37

lokmanb · 2024-01-23T18:54:08Z

This PR introduces a first development of MultiplierFESpace for the solution of constrained minimization problems. The idea is to be able to construct a MultiFESpace combining the usual finite element discretization on the one hand and Lagrange multipliers on the other. Here the Lagrange multipliers are additional unknowns and the MultiFESpace combined with MultiplierFESpace enables to assemble a global system which yields the solution of the constrained minimization problem as well as the associated Lagrange multipliers. The development is built on the constrained Poisson example.

… remains to be done

github-actions · 2024-01-23T19:03:50Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmarks:
- Target: 23 Jan 2024 - 19:01
- Baseline: 23 Jan 2024 - 19:03
Package commits:
- Target: fffb38
- Baseline: 7afd77
Julia commits:
- Target: 17cfb8
- Baseline: 17cfb8
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["entities", "nnodes"]`	0.91 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Target

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3244 MHz       1703 s          0 s        194 s       2853 s          0 s
       #2  3248 MHz       2109 s          0 s        251 s       2383 s          0 s
       #3  3242 MHz       1243 s          0 s        189 s       3314 s          0 s
       #4  3286 MHz       1301 s          0 s        175 s       3262 s          0 s
  Memory: 15.60690689086914 GB (13062.28515625 MB free)
  Uptime: 477.84 sec
  Load Avg:  1.16  1.26  0.69
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       2149 s          0 s        232 s       3969 s          0 s
       #2  3244 MHz       2952 s          0 s        318 s       3076 s          0 s
       #3  2504 MHz       1350 s          0 s        212 s       4784 s          0 s
       #4  2590 MHz       1409 s          0 s        199 s       4733 s          0 s
  Memory: 15.60690689086914 GB (12784.5390625 MB free)
  Uptime: 638.36 sec
  Load Avg:  1.06  1.16  0.75
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Target result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmark: 23 Jan 2024 - 19:1
Package commit: fffb38
Julia commit: 17cfb8
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["covo", "Quad", "explicit_step"]`	103.677 ms (5%)		69.30 MiB (1%)	3491
`["covo", "Quad", "integral_surface"]`	52.788 ms (5%)
`["covo", "Quad", "integral_volume"]`	22.881 ms (5%)
`["covo", "TriQuad", "explicit_step"]`	374.291 ms (5%)	20.391 ms	364.69 MiB (1%)	1634503
`["covo", "TriQuad", "integral_surface"]`	248.387 ms (5%)		210.06 MiB (1%)	1246116
`["covo", "TriQuad", "integral_volume"]`	56.768 ms (5%)		48.39 MiB (1%)	379526
`["entities", "edges2nodes"]`	1.552 ns (5%)
`["entities", "nedges"]`	1.552 ns (5%)
`["entities", "nnodes"]`	3.095 ns (5%)
`["entities", "nodes"]`	1.552 ns (5%)
`["mesh", "todo"]`	1.552 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3244 MHz       1703 s          0 s        194 s       2853 s          0 s
       #2  3248 MHz       2109 s          0 s        251 s       2383 s          0 s
       #3  3242 MHz       1243 s          0 s        189 s       3314 s          0 s
       #4  3286 MHz       1301 s          0 s        175 s       3262 s          0 s
  Memory: 15.60690689086914 GB (13062.28515625 MB free)
  Uptime: 477.84 sec
  Load Avg:  1.16  1.26  0.69
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmark: 23 Jan 2024 - 19:3
Package commit: 7afd77
Julia commit: 17cfb8
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["covo", "Quad", "explicit_step"]`	100.395 ms (5%)		69.30 MiB (1%)	3491
`["covo", "Quad", "integral_surface"]`	50.641 ms (5%)
`["covo", "Quad", "integral_volume"]`	22.176 ms (5%)
`["covo", "TriQuad", "explicit_step"]`	371.562 ms (5%)	20.696 ms	364.69 MiB (1%)	1634503
`["covo", "TriQuad", "integral_surface"]`	244.979 ms (5%)		210.06 MiB (1%)	1246116
`["covo", "TriQuad", "integral_volume"]`	59.232 ms (5%)		48.39 MiB (1%)	379526
`["entities", "edges2nodes"]`	1.552 ns (5%)
`["entities", "nedges"]`	1.552 ns (5%)
`["entities", "nnodes"]`	3.396 ns (5%)
`["entities", "nodes"]`	1.552 ns (5%)
`["mesh", "todo"]`	1.552 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       2149 s          0 s        232 s       3969 s          0 s
       #2  3244 MHz       2952 s          0 s        318 s       3076 s          0 s
       #3  2504 MHz       1350 s          0 s        212 s       4784 s          0 s
       #4  2590 MHz       1409 s          0 s        199 s       4733 s          0 s
  Memory: 15.60690689086914 GB (12784.5390625 MB free)
  Uptime: 638.36 sec
  Load Avg:  1.06  1.16  0.75
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	4

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           1
BogoMIPS:                           4890.86
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                     AMD-V
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           1 MiB (2 instances)
L3 cache:                           32 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Cpu Property	Value
Brand	AMD EPYC 7763 64-Core Processor
Vendor	:AMD
Architecture	:Unknown
Model	Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores	16 physical cores, 16 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 512, 32768) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 48 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

github-actions · 2024-01-23T19:06:27Z

Benchmark Results

	main	`3e7f7b8`...	t[main]/t[`3e7f7b8`...]
covo/Quad/explicit_step	0.104 ± 0.0036 s	0.103 ± 0.0036 s	1.01
covo/Quad/integral_surface	0.0516 ± 0.00064 s	0.0504 ± 0.00068 s	1.03
covo/Quad/integral_volume	23.4 ± 0.072 ms	22.4 ± 0.052 ms	1.05
covo/TriQuad/explicit_step	0.385 ± 0.023 s	0.385 ± 0.015 s	1
covo/TriQuad/integral_surface	0.261 ± 0.0027 s	0.261 ± 0.0018 s	1
covo/TriQuad/integral_volume	0.0709 ± 0.0025 s	0.0711 ± 0.002 s	0.997
entities/edges2nodes	1.55 ± 0.01 ns	1.55 ± 0.01 ns	1
entities/nedges	1.55 ± 0.01 ns	1.55 ± 0.01 ns	1
entities/nnodes	3.1 ± 0.009 ns	3.41 ± 0.01 ns	0.91
entities/nodes	1.55 ± 0.01 ns	1.55 ± 0.01 ns	1
mesh/todo	1.55 ± 0.01 ns	1.55 ± 0.01 ns	1
time_to_load	14.4 ± 0.038 s	14.5 ± 0.045 s	0.996

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

bmxam · 2024-01-29T11:46:44Z

src/fespace/fespace.jl

+    for i in 1:size
+        offset[:, i] .= i - 1
+    end
+    ndofs = ones(ncells(mesh), size) # Temporary allocation for development purposes


can you remove the comment since it seems that we finally kept this line

I suggest to update this comment: "TODO : use a Fill array to save memory space"

bmxam · 2024-01-29T11:52:59Z

src/assembler/assembler.jl

@@ -456,6 +456,20 @@ function _count_n_elts(
    return n
 end

+"""


Can you please merge the three _count_n_elts doc strings into a unique one, located at the top of the first method declaration? Take a look at src/fespace/fespace.jl -> TrialFESpace constructor for inspiration.

bmxam

We need some unit tests, especially on the dofhandler for the MultiplierFESpace. Maybe some tests taken from the tutorial configuration?

Moreover, a "global" test like Ghislain did for the DG Poisson would be nice. We can do it together during a live session.

lokmanb · 2024-02-15T22:03:01Z

Thanks for the review. I added a few unit tests for MultiplierFESpace. Concerning the "global" test, did you mean a test at the end of the corresponding example (with the error computation)?

github-actions · 2024-02-15T22:03:27Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmarks:
- Target: 15 Feb 2024 - 22:00
- Baseline: 15 Feb 2024 - 22:03
Package commits:
- Target: 51ac6f
- Baseline: d81437
Julia commits:
- Target: 17cfb8
- Baseline: 17cfb8
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["entities", "nnodes"]`	1.11 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Target

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3244 MHz       1457 s          0 s        211 s       4023 s          0 s
       #2  3244 MHz       1563 s          0 s        183 s       3949 s          0 s
       #3  2625 MHz       1576 s          0 s        200 s       3905 s          0 s
       #4  2445 MHz       1355 s          0 s        175 s       4166 s          0 s
  Memory: 15.60690689086914 GB (12887.88671875 MB free)
  Uptime: 573.41 sec
  Load Avg:  1.06  1.17  0.63
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3243 MHz       1690 s          0 s        249 s       5256 s          0 s
       #2  2445 MHz       1790 s          0 s        204 s       5205 s          0 s
       #3  2589 MHz       2068 s          0 s        234 s       4884 s          0 s
       #4  2605 MHz       1810 s          0 s        228 s       5163 s          0 s
  Memory: 15.60690689086914 GB (12950.4375 MB free)
  Uptime: 724.13 sec
  Load Avg:  1.05  1.11  0.69
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Target result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmark: 15 Feb 2024 - 22:0
Package commit: 51ac6f
Julia commit: 17cfb8
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["covo", "Quad", "explicit_step"]`	100.463 ms (5%)		69.28 MiB (1%)	3474
`["covo", "Quad", "integral_surface"]`	48.343 ms (5%)
`["covo", "Quad", "integral_volume"]`	22.284 ms (5%)
`["covo", "TriQuad", "explicit_step"]`	348.743 ms (5%)	18.799 ms	364.68 MiB (1%)	1634486
`["covo", "TriQuad", "integral_surface"]`	228.898 ms (5%)		210.06 MiB (1%)	1246116
`["covo", "TriQuad", "integral_volume"]`	56.576 ms (5%)		48.39 MiB (1%)	379526
`["entities", "edges2nodes"]`	1.552 ns (5%)
`["entities", "nedges"]`	1.552 ns (5%)
`["entities", "nnodes"]`	3.095 ns (5%)
`["entities", "nodes"]`	1.552 ns (5%)
`["mesh", "todo"]`	1.552 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3244 MHz       1457 s          0 s        211 s       4023 s          0 s
       #2  3244 MHz       1563 s          0 s        183 s       3949 s          0 s
       #3  2625 MHz       1576 s          0 s        200 s       3905 s          0 s
       #4  2445 MHz       1355 s          0 s        175 s       4166 s          0 s
  Memory: 15.60690689086914 GB (12887.88671875 MB free)
  Uptime: 573.41 sec
  Load Avg:  1.06  1.17  0.63
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmark: 15 Feb 2024 - 22:3
Package commit: d81437
Julia commit: 17cfb8
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["covo", "Quad", "explicit_step"]`	101.421 ms (5%)		69.28 MiB (1%)	3474
`["covo", "Quad", "integral_surface"]`	49.486 ms (5%)
`["covo", "Quad", "integral_volume"]`	21.929 ms (5%)
`["covo", "TriQuad", "explicit_step"]`	357.244 ms (5%)	19.052 ms	364.68 MiB (1%)	1634486
`["covo", "TriQuad", "integral_surface"]`	230.254 ms (5%)		210.06 MiB (1%)	1246116
`["covo", "TriQuad", "integral_volume"]`	58.516 ms (5%)		48.39 MiB (1%)	379526
`["entities", "edges2nodes"]`	1.552 ns (5%)
`["entities", "nedges"]`	1.552 ns (5%)
`["entities", "nnodes"]`	2.785 ns (5%)
`["entities", "nodes"]`	1.552 ns (5%)
`["mesh", "todo"]`	1.552 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3243 MHz       1690 s          0 s        249 s       5256 s          0 s
       #2  2445 MHz       1790 s          0 s        204 s       5205 s          0 s
       #3  2589 MHz       2068 s          0 s        234 s       4884 s          0 s
       #4  2605 MHz       1810 s          0 s        228 s       5163 s          0 s
  Memory: 15.60690689086914 GB (12950.4375 MB free)
  Uptime: 724.13 sec
  Load Avg:  1.05  1.11  0.69
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	4

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           1
BogoMIPS:                           4890.85
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                     AMD-V
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           1 MiB (2 instances)
L3 cache:                           32 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Cpu Property	Value
Brand	AMD EPYC 7763 64-Core Processor
Vendor	:AMD
Architecture	:Unknown
Model	Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores	16 physical cores, 16 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 512, 32768) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 48 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

bmxam · 2024-02-16T15:16:37Z

Thanks for the review. I added a few unit tests for MultiplierFESpace. Concerning the "global" test, did you mean a test at the end of the corresponding example (with the error computation)?

I meant encapsulating your whole example (or a simplified version) into a @testset with some kind of test at the end (on the error for instance). Like it is done here for the Poisson DG :

Bcube.jl/test/dof/test_assembler.jl

Line 213 in d81437d

@testset "Poisson DG" begin

github-actions · 2024-02-24T20:54:35Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmarks:
- Target: 24 Feb 2024 - 20:51
- Baseline: 24 Feb 2024 - 20:54
Package commits:
- Target: f5fc7b
- Baseline: f3166c
Julia commits:
- Target: 17cfb8
- Baseline: 17cfb8
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["covo", "Quad", "integral_volume"]`	1.05 (5%) ❌	1.00 (1%)
`["entities", "nnodes"]`	1.10 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Target

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3243 MHz       1480 s          0 s        176 s       2767 s          0 s
       #2  3243 MHz       2166 s          0 s        240 s       2016 s          0 s
       #3  2594 MHz       1031 s          0 s        173 s       3220 s          0 s
       #4  2445 MHz       1370 s          0 s        161 s       2890 s          0 s
  Memory: 15.60690689086914 GB (12954.9375 MB free)
  Uptime: 445.56 sec
  Load Avg:  1.07  1.21  0.64
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2685 MHz       1967 s          0 s        216 s       3757 s          0 s
       #2  2630 MHz       2393 s          0 s        266 s       3279 s          0 s
       #3  3242 MHz       1580 s          0 s        233 s       4128 s          0 s
       #4  2445 MHz       1527 s          0 s        179 s       4231 s          0 s
  Memory: 15.60690689086914 GB (12892.06640625 MB free)
  Uptime: 597.49 sec
  Load Avg:  1.01  1.13  0.71
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Target result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmark: 24 Feb 2024 - 20:51
Package commit: f5fc7b
Julia commit: 17cfb8
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["covo", "Quad", "explicit_step"]`	102.570 ms (5%)		69.28 MiB (1%)	3474
`["covo", "Quad", "integral_surface"]`	52.012 ms (5%)
`["covo", "Quad", "integral_volume"]`	23.232 ms (5%)
`["covo", "TriQuad", "explicit_step"]`	356.141 ms (5%)	19.649 ms	364.68 MiB (1%)	1634486
`["covo", "TriQuad", "integral_surface"]`	236.095 ms (5%)		210.06 MiB (1%)	1246116
`["covo", "TriQuad", "integral_volume"]`	56.506 ms (5%)		48.39 MiB (1%)	379526
`["entities", "edges2nodes"]`	1.552 ns (5%)
`["entities", "nedges"]`	1.552 ns (5%)
`["entities", "nnodes"]`	3.396 ns (5%)
`["entities", "nodes"]`	1.552 ns (5%)
`["mesh", "todo"]`	1.552 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3243 MHz       1480 s          0 s        176 s       2767 s          0 s
       #2  3243 MHz       2166 s          0 s        240 s       2016 s          0 s
       #3  2594 MHz       1031 s          0 s        173 s       3220 s          0 s
       #4  2445 MHz       1370 s          0 s        161 s       2890 s          0 s
  Memory: 15.60690689086914 GB (12954.9375 MB free)
  Uptime: 445.56 sec
  Load Avg:  1.07  1.21  0.64
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Time of benchmark: 24 Feb 2024 - 20:54
Package commit: f3166c
Julia commit: 17cfb8
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["covo", "Quad", "explicit_step"]`	101.335 ms (5%)		69.28 MiB (1%)	3474
`["covo", "Quad", "integral_surface"]`	52.709 ms (5%)
`["covo", "Quad", "integral_volume"]`	22.065 ms (5%)
`["covo", "TriQuad", "explicit_step"]`	357.701 ms (5%)	19.175 ms	364.68 MiB (1%)	1634486
`["covo", "TriQuad", "integral_surface"]`	231.927 ms (5%)		210.06 MiB (1%)	1246116
`["covo", "TriQuad", "integral_volume"]`	57.737 ms (5%)		48.39 MiB (1%)	379526
`["entities", "edges2nodes"]`	1.552 ns (5%)
`["entities", "nedges"]`	1.552 ns (5%)
`["entities", "nnodes"]`	3.085 ns (5%)
`["entities", "nodes"]`	1.552 ns (5%)
`["mesh", "todo"]`	1.552 ns (5%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["covo", "Quad"]
["covo", "TriQuad"]
["entities"]
["mesh"]

Julia versioninfo

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.2.0-1019-azure #19~22.04.1-Ubuntu SMP Wed Jan 10 22:57:03 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2685 MHz       1967 s          0 s        216 s       3757 s          0 s
       #2  2630 MHz       2393 s          0 s        266 s       3279 s          0 s
       #3  3242 MHz       1580 s          0 s        233 s       4128 s          0 s
       #4  2445 MHz       1527 s          0 s        179 s       4231 s          0 s
  Memory: 15.60690689086914 GB (12892.06640625 MB free)
  Uptime: 597.49 sec
  Load Avg:  1.01  1.13  0.71
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	4

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           1
BogoMIPS:                           4890.86
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                     AMD-V
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           1 MiB (2 instances)
L3 cache:                           32 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Cpu Property	Value
Brand	AMD EPYC 7763 64-Core Processor
Vendor	:AMD
Architecture	:Unknown
Model	Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores	16 physical cores, 16 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 512, 32768) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 48 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

ghislainb · 2024-01-24T15:02:20Z

src/fespace/fespace.jl

+    for i in 1:size
+        offset[:, i] .= i - 1
+    end
+    ndofs = ones(ncells(mesh), size) # Temporary allocation for development purposes


Ones or Fill from FillArrays.jl could be considered

ghislainb · 2024-02-02T10:24:13Z

src/fespace/fespace.jl

+    for i in 1:size
+        offset[:, i] .= i - 1
+    end
+    ndofs = ones(ncells(mesh), size) # Temporary allocation for development purposes


I suggest to update this comment: "TODO : use a Fill array to save memory space"

Lokman Bennani added 6 commits December 1, 2023 14:32

[WIP] added MultplierFESpace

f84e698

Merge branch 'main' into dev_multiplierFeSpace

225a13f

added MultiplierFESpace for Lagrange multipliers

0da2168

Merge branch 'main' into dev_multiplierFeSpace

05bb7e7

Merge branch 'main' into dev_multiplierFeSpace

200c85c

Added a _count_n_elt function for BoundaryFaceDomains, implementation…

9f9687f

… remains to be done

ghislainb requested review from ghislainb and bmxam January 23, 2024 22:17

bmxam reviewed Jan 29, 2024

View reviewed changes

bmxam requested changes Jan 29, 2024

View reviewed changes

lokmanb added 2 commits February 15, 2024 17:53

merging doc strings for _count_n_elts and cleaning MultiplierFESpace

34ae323

Adding a few unit tests for MultiplierFESpace

a21688c

lokmanb added 2 commits February 24, 2024 21:16

added testset for constrained Poisson

98cd800

Merge branch 'main' into dev_multiplierFeSpace

3e7f7b8

bmxam approved these changes Feb 24, 2024

View reviewed changes

ghislainb approved these changes Feb 25, 2024

View reviewed changes

ghislainb merged commit af0d7f4 into main Feb 25, 2024
9 checks passed

ghislainb deleted the dev_multiplierFeSpace branch February 25, 2024 10:25

Addition of multiplierFESpace #37

Addition of multiplierFESpace #37

Conversation

lokmanb commented Jan 23, 2024

github-actions bot commented Jan 23, 2024

Judge result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

github-actions bot commented Jan 23, 2024 • edited Loading

Benchmark Results

Benchmark Plots

bmxam Jan 29, 2024

Choose a reason for hiding this comment

ghislainb Feb 2, 2024

Choose a reason for hiding this comment

bmxam Jan 29, 2024

Choose a reason for hiding this comment

bmxam left a comment

Choose a reason for hiding this comment

lokmanb commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

Judge result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

bmxam commented Feb 16, 2024

github-actions bot commented Feb 24, 2024

Judge result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Bcube.jl/Bcube.jl

Job Properties

Results

github-actions bot commented Jan 23, 2024 •

edited

Loading