MessageFeed.latest_update for simple race-free waits
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
mhidalgo-bdai
requested review from
jbarry-bdai and
amessing-bdai
as code owners
amessing-bdai
approved these changes
Nov 20, 2024
khughes-bdai
approved these changes
Nov 20, 2024
mhidalgo-bdai
deleted the
mhidalgo-bdai/race-free-latest-message-waits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageFeed.latestyields what's available in buffers andMessageFeed.updatecan be used to wait for what comes next, but neither helps the common wait-for-a-message use case. This is particularly bad for message feeds tied to transient local ROS 2 topic subscriptions, as both race with a single message dispatch.Thus, this patch adds
MessageFeed.latest_updateto cover for this.