Deferred message filter/feed activation for race-free setups #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
khughes-bdai
approved these changes
Nov 20, 2024
Signed-off-by: Michel Hidalgo <[email protected]>
mhidalgo-bdai
requested review from
jbarry-bdai and
amessing-bdai
as code owners
Signed-off-by: Michel Hidalgo <[email protected]>
mhidalgo-bdai
force-pushed
the
mhidalgo-bdai/deferred-feed-start
branch
from
a581ebe
to
d889790
Compare
amessing-bdai
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message filters (and feeds too, by transitivity) can easily lose messages when these are chained while messages are being dispatched. This is a very real possibility when e.g. setting up topic subscriptions against a
Nodethat is spinning in the background.To alleviate this, this patch introduces
start()/stop()semantics to both message filters and feeds. Default behavior remains the same, but users can now choose not toautostartthem and defer it until after all chaining is complete.