-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EK-49] Organize ros_utilities
for release
#133
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
minor question -- is it worth mentioning somewhere in the readme that the proto2ros stuff used to live here, and has now moved to another repo?
Good idea. Adding it ⚙️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (i agree with adding a quick note to readme)
also looks like we just got the |
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
- [ ] Lint and unit tests pass locally | ||
- [ ] I have added tests that prove my changes are effective | ||
- [ ] I have added necessary documentation to communicate the changes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ros-based tests use the domain coordinator
Holding this up until we've sorted out the package rename. |
This patch re-organizes this repository in preparation for its release to ROS 2. In particular, it:
proto2ros*
packages, as these will now live in their own repository.bdai_ros2_wrappers
torainbows
to suit upcoming changes.bdai_ros2_wrappers
is kept as an alias torainbows
.