Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EK-49] Organize ros_utilities for release #133

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mhidalgo-bdai
Copy link
Contributor

This patch re-organizes this repository in preparation for its release to ROS 2. In particular, it:

  • Removes proto2ros* packages, as these will now live in their own repository.
  • Renames bdai_ros2_wrappers to rainbows to suit upcoming changes.
    • Yet bdai_ros2_wrappers is kept as an alias to rainbows.
  • Polishes containerization and packaging.

Copy link
Contributor

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
minor question -- is it worth mentioning somewhere in the readme that the proto2ros stuff used to live here, and has now moved to another repo?

@mhidalgo-bdai
Copy link
Contributor Author

is it worth mentioning somewhere in the readme that the proto2ros stuff used to live here, and has now moved to another repo?

Good idea. Adding it ⚙️

Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (i agree with adding a quick note to readme)

Copy link
Contributor

also looks like we just got the [email protected] alias -- can we update that here too?

Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
@mhidalgo-bdai mhidalgo-bdai marked this pull request as ready for review December 4, 2024 13:15
- [ ] Lint and unit tests pass locally
- [ ] I have added tests that prove my changes are effective
- [ ] I have added necessary documentation to communicate the changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ros-based tests use the domain coordinator

@mhidalgo-bdai
Copy link
Contributor Author

Holding this up until we've sorted out the package rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants