Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SW-949] Add mission client to wrapper #113

Merged
merged 9 commits into from
May 29, 2024

Conversation

tcappellari-bdai
Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai commented May 29, 2024

Unsure how but when we reverted this branch and then reopened the PR and merged it, somehow only the newest changes had actually gotten merged in so most of the work wasn't actually merged. Realized this while working on the spot_ros2 side of things and CI failed.

Added in wrapper for mission services

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tcappellari-bdai and the rest of your teammates on Graphite Graphite

@coveralls
Copy link

coveralls commented May 29, 2024

Pull Request Test Coverage Report for Build 9292173419

Details

  • 34 of 97 (35.05%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 46.639%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/wrapper.py 7 8 87.5%
spot_wrapper/spot_mission_wrapper.py 27 89 30.34%
Totals Coverage Status
Change from base Build 9193335365: -0.4%
Covered Lines: 1686
Relevant Lines: 3615

💛 - Coveralls

@tcappellari-bdai tcappellari-bdai marked this pull request as ready for review May 29, 2024 19:47
@tcappellari-bdai tcappellari-bdai merged commit 8aca7b7 into main May 29, 2024
6 checks passed
@tcappellari-bdai tcappellari-bdai deleted the SW-949-add-mission-client-in-spot-wrapper branch May 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants