fix: pinned np to 1.25.2 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschweig
requested review from
jbarry-bdai,
heuristicus,
amessing-bdai,
khughes-bdai and
tcappellari-bdai
as code owners
mhidalgo-bdai
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Thanks for the contribution @mschweig! Mind to sign your commit for the DCO check to pass?
Signed-off-by: Manuel Schweiger <[email protected]>
Signed-off-by: Manuel Schweiger <[email protected]>
mhidalgo-bdai
approved these changes
Jan 27, 2025
Pull Request Test Coverage Report for Build 12996734647Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip dependency resolver installs numpy >2 with
[install_spot_ros2.sh](https://github.com/bdaiinstitute/spot_ros2/blob/main/install_spot_ros2.sh)Conflicts with ROS2 and several packages such as
cv_bridgePinned numpy to 1.25.2 in
requirements.txtFixes:
bdaiinstitute/spot_ros2#492
bdaiinstitute/spot_ros2#555