Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated requirements to use ROS2 messages 3.3.2 #77

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

gremigi-bdai
Copy link
Contributor

@gremigi-bdai gremigi-bdai commented Oct 31, 2023

In this PR I'm updating the requirements for the spot_ros2 installation script to download and install the debian packages containing the ROS2 messages for Post SDK 3.3.2.

spot_wrapper is a submodule of spot_ros2 package and this PR must be approved before the following:

bdaiinstitute/spot_ros2#177

@gremigi-bdai gremigi-bdai changed the title Updated requirements for ROS messages 3.3.2 Updated requirements to use ROS2 messages 3.3.2 Oct 31, 2023
@gremigi-bdai gremigi-bdai marked this pull request as ready for review October 31, 2023 16:57
Copy link
Collaborator

@bhung-bdai bhung-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this but I think there's a significant amount of stakeholders to notify about this change.

@jbarry-bdai
Copy link
Collaborator

Is this a breaking change? I know the BD protos are supposed to be backwards compatible.

@amessing-bdai
Copy link
Collaborator

amessing-bdai commented Oct 31, 2023

They list the breaking changes in their release notes. These are the only ones.

When the robot loses connection with an E-stop endpoint, an attempt to power on the robot will now return STATUS_KEEP_ALIVE_MOTOR_OFF instead of STATUS_ESTOPPED. In python code it will raise the KeepaliveMotorsOffError exception instead of EstoppedError.

Some malformed Graph Nav graphs were previously accepted, but would leave the service in a bad state. These graphs are now explicitly rejected during upload.

I have searched for both STATUS_ESTOPPED and EstoppedError in both spot_ros2 and spot_ros. Neither repo has them explicitly.

@bhung-bdai
Copy link
Collaborator

Is this a breaking change? I know the BD protos are supposed to be backwards compatible.

My very basic testing hasn't had issues so far, but it's by no means comprehensive.

@amessing-bdai amessing-bdai merged commit ae0f808 into main Nov 16, 2023
2 checks passed
@amessing-bdai amessing-bdai deleted the pr-update-bosdyn-msgs branch November 16, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants