Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose builtin mocks state #97

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Expose builtin mocks state #97

merged 1 commit into from
Mar 25, 2024

Conversation

mhidalgo-bdai
Copy link
Collaborator

Precisely what the title says. In hindsight, I should've exposed it all from the start. Now I find it necessary for integration testing downstream.

@mhidalgo-bdai
Expose builtin mocks state
6275eb5 
Signed-off-by: Michel Hidalgo <[email protected]>
@mhidalgo-bdai mhidalgo-bdai self-assigned this Mar 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8425312977

Details

  • 16 of 20 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 96.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/testing/mocks/payload_registration.py 2 3 66.67%
spot_wrapper/testing/mocks/robot_state.py 12 15 80.0%
Totals Coverage Status
Change from base Build 8424700294: -0.1%
Covered Lines: 1880
Relevant Lines: 1955
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8425312977

Details

  • 16 of 20 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 96.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/testing/mocks/payload_registration.py 2 3 66.67%
spot_wrapper/testing/mocks/robot_state.py 12 15 80.0%
Totals Coverage Status
Change from base Build 8424700294: -0.1%
Covered Lines: 1880
Relevant Lines: 1955
💛 - Coveralls

@mhidalgo-bdai mhidalgo-bdai merged commit e238ad8 into main Mar 25, 2024
6 checks passed
@mhidalgo-bdai mhidalgo-bdai deleted the mhidalgo-bdai/expose-mocks-state branch March 25, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amessing-bdai amessing-bdai amessing-bdai approved these changes

@jbarry-bdai jbarry-bdai Awaiting requested review from jbarry-bdai jbarry-bdai is a code owner

@heuristicus heuristicus Awaiting requested review from heuristicus heuristicus is a code owner

Assignees

@mhidalgo-bdai mhidalgo-bdai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhidalgo-bdai @coveralls @amessing-bdai