[pull] master from qbittorrent:master #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Now drop action is only allowed on transfer list, previously it was on main window. Having drop action on the whole main window is not preferred because it could allow drop action on other unrelated widgets, such as execution log or RSS widget which is unexpected behavior. PR #21332.
PR #21371. Signed-off-by: Thomas Piccirello <[email protected]>
There is no reason for `WebUI` class to retain this information. PR #21373.
WebUI: CSS/styling improvements
This PR adds 'Engine' column to Search table. I also fixed inconsistent naming and renamed 'Search engine' column to 'Engine URL'. PR #21397.
Torrent hashes in tracker list are now kept in sets instead of arrays. PR #21405.
Migrated last remnants of QVector to Qlist, reference #21016 (comment) onward. PR #21407.
Incorrect row ID prevented the "Torrent content removing mode" option from being displayed on some platforms. PR #21481.
Just like in GUI, confirmation dialog shows up if it's possible to enable Auto TMM for any selected torrent. Right now it's not possible to properly test all cases in the WebUI because context menu completely hides TMM option when some torrents have it enabled and some not (no tri-state) - but that's something to add in another PR. PR #21378.
router.utorrent.com has been dead for a long time. router.bittorrent.com died about a month or two ago. dht.aelitis.com doesn't work either. It is no longer possible to get DHT nodes from them. Added router.silotis.us. Only ipv6! PR #21296.
This help identifying threads when debugging. The naming scheme is using 'class/function name + variable name'. Note that the length limitaion is 16 chars on linux. On Windows, the limit is 32767 chars. PR #21403.
This turn on assertions from qbt codebase so that testers can verify the assertions really hold. PR #21499.
* Bumped numerous revisions * Removed obsolete exclusions (files/folders were removed previously) * Implement fix/workaround for "false positives" (typos/codespell) PR #21460.
This PR further reduces Mootools usage. PR #22220.
The `announce_port` setting permits to overwrite the port passed along to trackers as the `&port=` parameter. If left as the default, the listening port is used. This setting is only meant for very special cases where a seed's listening port differs from the effectively exposed port (e.g., through external NAT-PMP). See arvidn/libtorrent#7771 for an example use-case. This PR adds the relevant setting alongside the existing `announce_ip` setting. PR #21692.
Bump Boost version. Boost::asio 1.76 has a bug that prevents compiling in C++20 mode. PR #22245.
This PR fixes a memory leak in context menus. Previously, for some reason, each menu retained references to its target elements without utilizing them further. Since the targets property was accessible/reachable from the root (window object), these references persisted even after the elements were removed from the DOM, preventing them from being garbage collected. It's easily reproducible - just add a decent amount of torrents, switch between categories multiple times, then capture heap/detached elements snapshot in the Memory tab (Chrome dev tools). The number of detached elements will continue to increase after each category switch and they won't be cleaned up. [More context](https://github.com/qbittorrent/qBittorrent/pull/22220/files#r1941137796) PR #22234.
This also fix share ratio dialog which had been broken in recent cleanup. PR #22252.
Also fix a few variable names along the way. PR #22264.
Also migrate to .mjs format. PR #22263.
Upstream now defaults to static runtime and the previous URL is invalid now. Upstream commits: * linuxdeploy/linuxdeploy@c28054b * linuxdeploy/linuxdeploy-plugin-qt@ce5291e Also fuse2 is not needed now as stated on: https://github.com/AppImage/type2-runtime?tab=readme-ov-file#type2-runtime- PR #22286.
This avoids an unnecessary check to the container internal atomic variable and prevents potential detachment. PR #22280.
The `round()` returning floating point number is not a good idea. This is due to floating point representation is imprecise and sometimes it cannot faithfully represent a number, for example `0.09 + 0.01 !== 0.1 `. Therefore, it should be avoided and/or utilize other function to achieve the goal. Also, improve `window.qBittorrent.Misc.toFixedPointString()` and add test cases. PR #22281.
Mainly it is about moving each platform code to its own file. PR #22279.
WebUI v5.1 fixes
This PR fixes a bug where the sort icon did not update correctly after reordering columns. Steps to reproduce: 1. Sort a column 2. Move it to a different position 3. The sort icon remains in its original location PR #22299.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )