Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat fix for ConstructionBase 1.5.7 #123

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

omus
Copy link
Member

@omus omus commented Aug 28, 2024

Fixing the following issue on Julia 1.6 with ConstructionBase 1.5.7:

Macro invocation doesn't require Legolas module name in caller's scope: Error During Test at /home/runner/work/Legolas.jl/Legolas.jl/test/runtests.jl:208
  Got exception outside of a @test
  UndefVarError: check_patch_properties_exist not defined
  Stacktrace:
    [1] setproperties(r::Main.Namespace91.A91V1, patch::NamedTuple{(:a,), Tuple{Int64}})
      @ Legolas.LegolasConstructionBaseExt ~/work/Legolas.jl/Legolas.jl/ext/LegolasConstructionBaseExt.jl:20
    [2] set(obj::Main.Namespace91.A91V1, l::PropertyLens{:a}, val::Int64)
      @ Accessors ~/.julia/packages/Accessors/hSII3/src/optics.jl:401
    [3] macro expansion
      @ ~/work/Legolas.jl/Legolas.jl/test/runtests.jl:218 [inlined]
    [4] macro expansion
      @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
    [5] top-level scope
      @ ~/work/Legolas.jl/Legolas.jl/test/runtests.jl:211
    [6] include(fname::String)
      @ Base.MainInclude ./client.jl:444
    [7] top-level scope
      @ none:6
    [8] eval
      @ ./boot.jl:360 [inlined]
    [9] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:261
   [10] _start()
      @ Base ./client.jl:485

https://github.com/beacon-biosignals/Legolas.jl/actions/runs/10600836570/job/29379251401?pr=122#step:6:214

@omus
Copy link
Member Author

omus commented Aug 28, 2024

@ararslan can you review as you originally added this extension in #112?

Copy link
Member

@kleinschmidt kleinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the relationship with 1.6 is just a weakdeps thing (the construction base dep doesn't even get install on the julia 1 tests...).

Might be easier to just bite the bullet and declare the compat bounds as 1.5.7...

@omus omus requested a review from kleinschmidt August 28, 2024 20:47
@omus omus mentioned this pull request Aug 28, 2024
@kleinschmidt kleinschmidt merged commit 69e11c7 into main Aug 28, 2024
5 of 6 checks passed
@kleinschmidt kleinschmidt deleted the cv/construction-base-1.5.7-compat branch August 28, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants