Adjust to upcoming Julia 1.12 change in implicit world age increment #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1.12, we'll be cleaning up and making consistent when world age increment happens. This package is currently relying on implicit world age increments that may go away in 1.12. See JuliaLang/julia#56509. This PR adds appropriate annotations that the world age increment is required because the `_generate_*` invocations in the macro read the result of the previous eval. This PR strictly retains existing behavior. A potentially better solution may be to `invokelatest` the `_generate_*` functions, which would also allow this code to work at non-toplevel (which may nor may not be desirable).
kleinschmidt
approved these changes
Nov 19, 2024
|
Could I get a version tagged that includes this PR? That way PkgEval will be happy and keep testing this package and its downstreams once the upstream PR merges. |
|
v0.5.23 is released with this change, ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.12, we'll be cleaning up and making consistent when world age increment happens. This package is currently relying on implicit world age increments that may go away in 1.12. See JuliaLang/julia#56509. This PR adds appropriate annotations that the world age increment is required because the
_generate_*invocations in the macro read the result of the previous eval. This PR strictly retains existing behavior. A potentially better solution may be toinvokelatestthe_generate_*functions, which would also allow this code to work at non-toplevel (which may nor may not be desirable).