Fix Arrow deserialization for FlatArray
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests currently fail with the latest compatible versions of this
package's dependencies because deserializing a `FlatArray` from Arrow
ends up calling a `FlatArray` constructor method that doesn't exist:
`FlatArray(vec, size)`. What it should actually call is the inner
constructor, `FlatArray{T}(vec, size)`. To fix this, we can define a
method for `fromarrow` from ArrowTypes to simply call the inner
constructor. An analogous change is not needed for `Weights` because the
method that `fromarrow` calls by default does exist in that case.
Note that no new tests were added. This is because the current tests
actually cover this case.
Co-Authored-By: Angelica Patino <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 94.11% 94.33% +0.22%
==========================================
Files 2 2
Lines 51 53 +2
==========================================
+ Hits 48 50 +2
Misses 3 3 ☔ View full report in Codecov by Sentry. |
kleinschmidt
approved these changes
Nov 20, 2023
Based on the error, my only guess would be ArrowTypes, which this package uses like a submodule of Arrow rather than as a distinct dependency. That means we effectively inherit Arrow's compat bound on ArrowTypes. |
|
I believe it was Arrow 2.6. A lot of our internal packages that use LegolasFlux compat bounded to 2.5 to avoid this and other similar issues (but I guess we did not file an issue here or anything 😅). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests currently fail with the latest compatible versions of this package's dependencies because deserializing a
FlatArrayfrom Arrow ends up calling aFlatArrayconstructor method that doesn't exist:FlatArray(vec, size). What it should actually call is the inner constructor,FlatArray{T}(vec, size). To fix this, we can define a method forfromarrowfrom ArrowTypes to simply call the inner constructor. An analogous change is not needed forWeightsbecause the method thatfromarrowcalls by default does exist in that case.Note that no new tests were added. This is because the current tests actually cover this case.
Originally encountered by then pair debugged with @patinoam.