Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use upstream fcollect #9

Merged
merged 1 commit into from
Oct 20, 2021
Merged

use upstream fcollect #9

merged 1 commit into from
Oct 20, 2021

Conversation

ericphanson
Copy link
Member

@ericphanson ericphanson commented Oct 20, 2021

Since the fix has been upstreamed: FluxML/Functors.jl#25

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #9 (a54ceae) into main (aaa94fd) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   94.54%   93.75%   -0.80%     
==========================================
  Files           2        2              
  Lines          55       48       -7     
==========================================
- Hits           52       45       -7     
  Misses          3        3              
Impacted Files Coverage Δ
src/functors.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa94fd...a54ceae. Read the comment docs.

Copy link
Member

@haberdashPI haberdashPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericphanson ericphanson merged commit 9f2903f into main Oct 20, 2021
@ericphanson ericphanson deleted the eph/update-functors branch October 20, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants