This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
First pass at disk quotas #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and I do plan to update the README as well but will save that for a time when the implementation is final. |
Per DEP-0003, a "0" means "no quota". This ignores quotas when `diskQuota` is set to 0.
pfrazee
suggested changes
Apr 8, 2019
When we're over quota there is no reason to stop serving chunks of a dat
out to people who request them. We simply need to stop incoming updates
to the dat, so what we do is leave the network and the re-join with
{download: false} passed as an option to the dat.
Per @pfrazee's code review, it makes more sense for this function to live in `server.js`.
pfrazee
suggested changes
Apr 18, 2019
| // update the disk space seems right | ||
| console.log(config.diskUsage, config.diskQuota, config.diskUsage/config.diskQuota) | ||
| if (config.diskUsage < config.diskQuota) { | ||
| config.dats.forEach(datCfg => dat.start(datCfg, config)) |
There was a problem hiding this comment.
This isn't the correct usage of dat.start. See https://github.com/beakerbrowser/homebase/blob/master/lib/server.js#L141 -- the method returns a server instance which is supposed to be integrated into the top level express server.
|
|
||
| // align our estimated disk usage with real disk usage every 5 minutes | ||
| updateDiskUsage(this) | ||
| setInterval(updateDiskUsage.bind(this), 1000*60*5, this) |
There was a problem hiding this comment.
I'd recommend calling updateDiskUsage and setting up the interval from server.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to implement the
diskQuotaanddiskUsagefeatures in DEP-0003. This is a draft implementation, and my first homebase contribution, so I'm sure there is a lot of room for improvement and it could use an extra set of eyes. There are a bunch of console logs in here which won't be in the final version, as well, but are included for the sake of debugging during development.Basic features follow.
Add a
diskQuotavariable to the configThere is now a
diskQuotafield in the config that accepts a quota in bytes. I couldn't find a library that parses "human" byte strings like "100MB" or "1GB" to a byteNumber, and in fact that might be an antipattern so I'm just sticking to raw bytes. Since the users of homebase are sysadmins of some flavor, I think this should be okay.Return
diskQuotaanddiskUsageon GET account callWhen you send GET
/v1/accounts/account, you now get the quota and space used, per DEP-0003.Rejects a new pinning request if accepting the request would put the user over quota
On a call to
/v1/dats/add, the sparse statistics for the dat are downloaded. This tells us how big the full dat is, and we do the math based on the existingdiskUsageand return a 403 error and message,User is over quota: requested dat is ${datSize} bytes, user has ${config.diskQuota - config.diskUsage} bytes remaining.On downloading a chunk of a dat, check to see if we are over quota
On a
'download'event, if the chunk being downloaded would put us over quota, we stop downloading this particular dat.We keep a running
estimatedDiskUsagethat is occasionally synced to the "real"diskUsageso we don't have to parse the entire directory tree every time a chunk is downloaded from an active dat.estimatedDiskUsageis synchronized to the real value every five minutes and on startup.Re-allow all downloads if we go back under quota
When we check the real
diskUsageevery five minutes, if we are under quota, we restart all dats, which allows for downloads again. Currently this will restart all dats every five minutes while we're under quota. I'm not sure if this is a "free" operation for a dat that is currently already active. Maybe we should makeactiveDatsavailable somehow and only restart dats that are not in that object?