Fix: Return error and exception when endpoint app raises an exception #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleviminzi
requested review from
nickpetrovic,
mernit,
luke-lombardi and
jsun-m
luke-lombardi
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
LGTM - cc @mernit to communicate the change in behavior to users. Basically now if your endpoint throws an error you'll get a 500 instead of a 200 as you do now.
@mernit For more context, @dleviminzi's original message:
|
|
@luke-lombardi we already communicated this in Slack, I told them we'd release it Thursday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve BE-2148
Once the warning message has been circulated and users have had time to update any handling logic we can merge this.
It is the exact same thing as #791, but we need to wait to release