Bugfix/enable usage of runtime.exs to configure #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the Purpose?
runtime.exs
to configure the packageConfig
module instead ofMix.Config
to remove deprecated warningsWhat was the approach?
Elixir added support for using a
runtime.exs
file to configure the application. This enablesconfiguration to be resolved at application startup. However, the API Key was being stored as
a module attribute (
@key
) which was being resolved at compile time. This caused the following error:{:error, %{message: "The supplied authentication is invalid", status: 401}}
This was due to the API Key not being set to a value during compilation. To fix this the module attribute
was removed and the API Key is resolved when needed.
Upgraded the dependency version to fix the following error
Are there any concerns to addressed further before or after merging this PR?
Run
mix deps.get
Mentions?
@manuelgeek
@sigu
@kamalogudah
@TraceyOnim
Issue(s) affected?
Configuration using runtime.exs does not work #95