Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/3] Very minor NFC (emerged from ruff) #111

Merged
merged 1 commit into from
Sep 30, 2023
Merged

[1/3] Very minor NFC (emerged from ruff) #111

merged 1 commit into from
Sep 30, 2023

Conversation

PhilipVinc
Copy link
Collaborator

Some very very minor minor changes that I am removing from #110 to make review easier.
Those were detected by running ruff over the codebase.

The main question I have is why you were using __copy__()instead of copy.copy (which ok, just calls __copy__, but seems to me a bit more readable..)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6364520918

  • 14 of 14 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6282717489: 0.0%
Covered Lines: 938
Relevant Lines: 938

💛 - Coveralls

@PhilipVinc PhilipVinc changed the title Very minor NFC (emerged from ruff) [1/3] Very minor NFC (emerged from ruff) Sep 30, 2023
Copy link
Member

@wesselb wesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're totally right that using copy is more clear! Thanks for this. :)

@wesselb wesselb merged commit 892a513 into master Sep 30, 2023
10 of 12 checks passed
@PhilipVinc PhilipVinc deleted the pv/minor branch September 30, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants