Bringing 4.36 back up to the main/master branch #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parameters
- Form field tests on R package require identical request and response JSON for form fields
- Therefore must update R package test to use new attachment type structure (notably removing "kind" property and including "captureMethods" property)
- However attachment type deserialisation remains backwards compatible, so users who pass in old structure will not be blocked by the changes to attachment type
AI-3786: Fix tests for attachment type fields
AI-3786: Fix test (use char vector rather than list, uppercase enums)
AI-3786: Fix tests (comparison of potentially unordered char vectors)
…utine for query responses
Revert test fixes for AI-3786
|
Will do this locally instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.36 is behind master. I'd like to bring it back up to the speed to facilitate the eventual merge back into master.