Apply ordering for jobs when using Bull queue #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
fix-desc-ordering-for-bull-jobs
branch
from
2d99202 to
1e1f891
Compare
roggervalf
force-pushed
the
fix-desc-ordering-for-bull-jobs
branch
from
0539e0b to
c5d21a0
Compare
roggervalf
changed the title
|
Hi @bradvogel, could you please help me with some 👀 in this PR when you have some free time |
|
I don't have a way to test the Bull queue but I trust that you've tested this. The code looks good. Separately, it'd be great to have another example (apart from the Bee Queue example in #326) that uses Bull. |
bradvogel
approved these changes
Feb 22, 2021
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When showing the jobs list by state, would be nice to have the last created jobs at the top, this PR tries to handle that by applying ordering desc by default. Also I added a dropdown for ordering so a user could choose how to order jobs by id
#240
tested with #326