Do not hard-crash on missing usernames #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
theospears
commented
Feb 29, 2024
| @@ -110,7 +110,7 @@ public class CurrentUserManager { | |||
| // Fetch a user from the persistent store | |||
| let request = NSFetchRequest<User>(entityName: "User") | |||
| // TODO: Handle (or at least log) an error here | |||
| let users = try? (context ?? container.viewContext).fetch(request) | |||
| let users = try? (context ?? container.newBackgroundContext()).fetch(request) | |||
There was a problem hiding this comment.
Drive by attempt to fix an unrelated crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using
username!to look up usernames. This would throw a fatal exception if the username was not available, crashing the app. In particular attempts to update HealthKit metrics could hit this after logging out from the app.Avoid this by centralizing the username lookup logic in the request manager making URLs in the app slightly more readable, and have it throw a catchable exception. This could theoretically cause issues in the case that a URL contains an additional
{username}string, but this seems unlikely.Testing:
Launched the app on my phone and checked it could load goals.
Signed out and did not immediately experience a crash.