Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "delta text" UI section #455

Merged
merged 1 commit into from
May 18, 2024
Merged

Remove the "delta text" UI section #455

merged 1 commit into from
May 18, 2024

Conversation

theospears
Copy link
Collaborator

@theospears theospears commented May 12, 2024

The app previously showed a section of numbers below the graph, e.g. (+1 +1 +2). These were from a time when "lanes" and "road" were part of the beeminder vocabulary and were pretty hard to understand, especially for do less goals.

We may wish to replace them with a table of what is due when, but for now just remove them.

Testing
Loaded the app and looked at a goal.

@theospears theospears changed the title Remove delta text Remove the "delta text" UI section May 12, 2024
Copy link
Collaborator Author

theospears commented May 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @theospears and the rest of your teammates on Graphite Graphite

@theospears theospears marked this pull request as ready for review May 12, 2024 03:56
Base automatically changed from remove-unused-goal-attributes to master May 18, 2024 05:53
@theospears theospears merged commit b8b586f into master May 18, 2024
3 checks passed
@theospears theospears deleted the remove-deltatext branch May 18, 2024 08:18
theospears pushed a commit that referenced this pull request Feb 24, 2025
)

## Summary
Includes the due by table in the goal, displaying the deltas on the goal
screen, where delta_text was previously displayed.
The user can quickly see, at the goal screen, how many of a thing to do
to obtain a number of days of safety.

*For UI changes including screenshots of before and after is great.*
![due by
deltas](https://github.com/user-attachments/assets/3900e32a-d902-4b95-873a-09b91973e0ed)

and now colored
![due by deltas,
colored](https://github.com/user-attachments/assets/fe97ffb0-c0d7-4e4a-b8e1-1f9b9f56f91b)
![due by deltas, colored, on
light](https://github.com/user-attachments/assets/b8e8db49-bd07-47f1-a103-dda1124cba16)



## Validation
built and ran the app in the simulator
viewed the goal screen of various goals


Relates to #209 
This shows the deltas on the goal screen. It does not display the entire
table and it does not show the totals nor does it show the dates. It
restores "amounts to do" previously provided by "delta text". (See #455)
Fixes #559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant