HealthKit integration uses own contexts for CoreData #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @theospears and the rest of your teammates on |
theospears
changed the title
krugerk
reviewed
Aug 9, 2024
| /// data with some lag, so we look a bit further back for safety | ||
| /// This does mean users who have very little buffer, and are not regularly unlocking their phone, may erroneously derail. There is nothing we | ||
| /// can do about this. | ||
| static let daysToUpdateOnChangeNotification = 7 |
There was a problem hiding this comment.
Previously there was a reminder about this in the form of a local notification. It was removed with #251 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure HealthKit integration with CoreData is thread safe and also doesn't risk using contexts which are no longer valid. Do this by making HealthKit related code use its own contexts, and minimize how much code it holds onto.
Testing:
Ran on device
Note: Current build is known to be quite crashy