gave notifications vc progressHUD, PTR, and section titles #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user can now manually trigger a refresh of the notification settings using the standard 'pull to refresh' mechanism also, the goals are sorting a to z rather than z to a and they are grouped by those using the defaults and those not
|
@theospears if you would like I could split this into either separate commits (where one can step through commits to see the atomic changes) or separate merge requests |
aligned on using switch
theospears
approved these changes
Oct 19, 2024
| case 1: | ||
| return self.goalsUsingDefaultNotifications.count | ||
| default: | ||
| return self.goalsUsingNonDefaultNotifications.count |
There was a problem hiding this comment.
Non blocking, but I'm a fan of explicitly handling all the expected cases and have default: log/report an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user can now manually trigger a refresh of the notification settings using the standard 'pull to refresh' mechanism
also, the goals are sorting a to z rather than z to a and they are grouped by those using the defaults and those not