animate placeholder to graph on goalvc #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krugerk
force-pushed
the
bugfix/608-harsh-jump-from-placeholder-to-graph
branch
from
90af5b9 to
56673db
Compare
krugerk
commented
Jan 7, 2025
krugerk
commented
Jan 8, 2025
theospears
reviewed
Jan 9, 2025
theospears
approved these changes
Jan 9, 2025
krugerk
commented
Jan 11, 2025
krugerk
commented
Jan 11, 2025
theospears
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses UIView.transition(with:...) when transitioning to the graph image (on the goalvc). The sudden swap of one image for the other was rather abrupt.
For UI changes including screenshots of before and after is great.
Validation
ran app in simulator
fixes #608
and is not quite as overreaching as #513