Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISRC identifiers from musicbrainz. #3814

Merged
merged 1 commit into from
May 12, 2021
Merged

Conversation

aereaux
Copy link
Contributor

@aereaux aereaux commented Dec 19, 2020

Description

This adds ISRC information as a tag. There are a couple of TODO I could use input on.

To Do

  • How to manage the issue where there are multiple related to a track. Right now I just ';'-join them, but we could just take the first or something.
  • How to add to files? There is apparently a tag for it in common formats (https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html#id12), but I'm not sure if anything needs to be added to mediafile.
  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@sampsyo
Copy link
Member

sampsyo commented Dec 19, 2020

Neat! This seems like a good start. I don't have a strong feeling about what to do with multiple ISRCs—joining with ; seems fine to me, but maybe others have more specific opinions.

It's possible to merge this independently of the necessary changes to MediaFile to get the tags written to metadata. But we will indeed need to add a tag mapping there to make that work.

@aereaux
Copy link
Contributor Author

aereaux commented May 12, 2021

Is there anything else that needs to be done before this is merged in beets? I added a changelog entry, and it seems to me that using ; is the best solution unless/until we get another way to have multi-valued tags.

There is also now a PR (not mine) in mediafile to add ISRC: beetbox/mediafile#42

@sampsyo
Copy link
Member

sampsyo commented May 12, 2021

Awesome; thanks for adding that! This looks good to go.

@sampsyo sampsyo merged commit 56e9026 into beetbox:master May 12, 2021
@JuniorJPDJ
Copy link

Multiple ISRCs? Isn't ISRC representing recording 1:1? Like one track can have only one ISRC?

@aereaux
Copy link
Contributor Author

aereaux commented May 12, 2021

@JuniorJPDJ: According to here it is supposed to be. But MB certainly allows many-many, such as https://beta.musicbrainz.org/recording/df569676-9c08-4bec-8137-daa122c04ca9 which has 5. One reason might be multiple remasters that are counted in MB as one recording.

Edit: more info here: https://community.metabrainz.org/t/why-does-picard-display-multiple-isrc-numbers-for-a-song/379470

@aereaux aereaux deleted the add_isrc branch May 12, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants