-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve config cmd #4188
Improve config cmd #4188
Conversation
Open file is changed: beets config --edit become beets config --open New command for edit config beets config --edit=import.write --value=true The supported type of setting are float. int, str and bool.
Hi there! Thanks for diving right in and prototyping something! Both of these are interesting ideas. Broadly speaking, it would be best to discuss the two new ideas independently. At a high level, I'm not sure about automatically creating a new configuration file on every execution—that seems like it could create some unintended side effects for people who don't expect This is far lower-level, but I would prefer to keep the CLI options named the way they are. That is, |
beet config -e -> Open config in editor beet config -s field=value -> Set the config
For now I removed the generation of the configuration file and add flag
I tested the preservation of comments and they are not preserved. So a modification of confuse is needed for that ? |
Yeah, we would indeed need to somehow do this in Confuse. One option would be tackling beetbox/confuse#52 first because that library (I think??) offers a better route to round-trippable YAML. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Add two major things:
Changed the config edit flag as follow:
New flag for editing settings from command-line. Edit flag accept the path of setting, the key must be present in the file.
It's impossible to modify option type (like string to integer). This command support boolean, string, integer and float and other type will be ignored.
To Do
docs/
to describe it.)docs/changelog.rst
near the top of the document.)