-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project to support django 5.0 #153
Conversation
0f0d476
to
2094bbf
Compare
tox.ini
Outdated
py3{8,9,10,11}-django42 | ||
py3{8,9,10,11,12}-django41 | ||
py3{8,9,10,11,12}-django42 | ||
py3{8,9,10,11,12}-django50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django 5.0 requires Python >= 3.10 according to the package metadata on PyPI.
After adjusting this line you also need to exclude Python < 3.10 for Django 5.0 in the test matrix of GHA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have made relevant changes.
ecad83d
to
cd7ea82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8914f21
to
83feb69
Compare
I have update the matrix please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're a hero! 🥇
Now, the tests for Python 3.12 fail for something that is not your fault! It would be awesome if you could fix that too, anyway.
The problem comes from deprecated aliases that were finally dropped in Python 3.12.
AFAICS, according to the tests, assertEquals
needs to be replaced by assertEqual
in the acceptance tests of the project.
File "tests/acceptance/steps/context-urlhelper.py", line 29, in is_baseurl_value
context.test.assertEquals(context.result, context.base_url)
^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BehaviorDrivenTestCase' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
File "tests/acceptance/steps/context-urlhelper.py", line 34, in baseurl_plus_path
context.test.assertEquals(context.result, context.base_url + url_path)
^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BehaviorDrivenTestCase' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
File "tests/acceptance/steps/context-urlhelper.py", line 54, in explicit_reverse
context.test.assertEquals(context.result, context.get_url(path))
^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BehaviorDrivenTestCase' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
File "tests/acceptance/steps/context-urlhelper.py", line 60, in get_model_url
context.test.assertEquals(context.result, context.get_url(path))
^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'BehaviorDrivenTestCase' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
If you'd replace assertEquals
in those places by assertEqual
then the two failing test jobs for Python 3.12 will also pass.
83feb69
to
2df1d55
Compare
I have made the changes from |
Thank you for contributing! 💯 🥇 |
My motto is Live long and Pull Request :) |
Update project to support django 5.0 and python 3.12