-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Vespa Lexical Search as an option to BEIR benchmark #76
base: main
Are you sure you want to change the base?
Include Vespa Lexical Search as an option to BEIR benchmark #76
Conversation
Introduce Vespa Lexical experiment into Beir
Improve Vespa lexical experiment
Hi @thigm85, thank you for providing this PR! in the next upcoming days, I will have a look at the PR. I'm happy to see Vespa being included within BEIR! I was busy shifting the repository last few weeks. Will soon merge with the development branch and later release with the next version of beir updates! Kind Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thigm85, I went through your PR. Thanks for all the code added and it looks good.
I have a few updates mentioned here.
- in
setup.py
can you addpyvespa
andtenacity
as optional dependencies something similar to what I have done fortensorflow
? Something like:
optional_packages = {
"tf" : ['tensorflow>=2.2.0', 'tensorflow-text', 'tensorflow-hub'],
"vespa": ["pyvespa", "tenacity"]
}
-
Can you create a
tests
folder within the main directory of BEIR and placetest_retrieval_lexical_vespa.py
inside thistests
folder. I currently do not have any unittests implemented for other methods, this will unify in future all unittests at one place. -
could you shift your example
benchmark_lexical_vespa.py
fromexamples/benchmarking
toexamples/retrieval/evaluation/lexical
because the other place contains all sample scripts to evaluate different lexical search and will be easier for the user to find it. -
Could you mention briefly on top of
benchmark_lexical_vespa.py
a few steps on how to run vespa lexical search? What must a user should have in place to run vespa search? Or how to download and run the vespa application? You can have a look at evaluate_bm25.py for reference.
Thank you! Will merge once it the small updates mentioned has been resolved.
Kind Regards,
Nandan Thakur
@NThakur20 could you take a look at this PR? The idea is to make it easier to benchmark Vespa applications using the BEIR datasets and framework. We started with Lexical Search but will make it more general later.