Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem in date picker of nothing happening when selecting year at end of date range #76

Closed
wants to merge 1 commit into from

Conversation

akc42
Copy link

@akc42 akc42 commented Feb 11, 2016

This fixes an issue whereby trying to use the year selector for a year at the end of the date range, if the calendar has not previously been set to ensure the date when the year is selected is within range, everything reverts to the old date.

This is confusing and frustrating to the user who may (I would say mostly, but that is just my way of thinking) select the year before going on to then select the date within the year.

@bendavis78
Copy link
Owner

While I agree the current behavior is probably undesirable, I think the same can be said if we implicitly set the date to the min/max as well. Ideally the user should be shown an error, or the developer should be able to handle invalid date values. I've created a new issue for this (#85). Feel free to continue discussion there.

@bendavis78 bendavis78 closed this Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants