patch rpc-bitcoin to be compatible with bitcoin core 28.0

[remcoros]

rpc-bitcoin is not compatible with Bitcoin Core 28.0, see vansergen/rpc-bitcoin#65

This PR is a (temporary?) solution while there is no new upstream package version available.

This uses the patch-package npm package.
The postinstall script in package.json is automatically executed when npm i runs and this patches rpc-bitcoin.

[d6n13l0l1v3r]

@benjamin-wilson do you plant to implement it or merge this branch in order to have support to core 28

[owenashurst]

Just tested locally and seems to fix the issue.

[d6n13l0l1v3r]

Just tested locally and seems to fix the issue.

my too I test locally with bitcoin 28 without any problem, including commit 2912dd5 because @remcoros don't sync yet

[remcoros]

Just tested locally and seems to fix the issue.

my too I test locally with bitcoin 28 without any problem, including commit 2912dd5 because @remcoros don't sync yet

there are no merge conflicts, so you can merge this PR to master and be up to date.

[nmfretz]

Thanks for this workaround @remcoros. I just went down a rabbithole after updating Core to v28 and tracked the issue down to the rpc-bitcoin library which seems to be a dead project at this point.

@benjamin-wilson do you have a timeline for testing+merging this and pushing an updated docker image? Public Pool is in the Umbrel app store and it would be great to update it with official docker images that maintain compatibility with Bitcoin Core v28. But if this is still a ways away I can just build an image to temporarily get Umbrel users back up and running until a new official image is released.

[benjamin-wilson]

The docker image on umbrel is maintained by someone else. I've contacted them and asked them to update.
https://github.com/smolgrrr

[nmfretz]

Wonderful. Thanks @benjamin-wilson, really appreciate it!

I know @smolgrrr well. He may be unavailable to update the public-pool-ui image, so I can handle that.
Edit: looks like his public-pool-ui image is up-to-date

Otherwise, he was using @sethforprivacy's public-pool image. Do you know if there are any major differences between your image and seth's?

[benjamin-wilson]

I didn't create or maintain the docker images, tbh I don't know

[nmfretz]

Alrighty, thanks again @benjamin-wilson

[smolgrrr]

sorry @benjamin-wilson @nmfretz was looking into this the other week, but got caught up with work. ive updated the ui image, but it doesn't yet work with the umbrel app-store framework (i was using a proxy for the ui before, but need to change that).
will jump into it again shortly.

[benjamin-wilson]

sorry @benjamin-wilson @nmfretz was looking into this the other week, but got caught up with work. ive updated the ui image, but it doesn't yet work with the umbrel app-store framework (i was using a proxy for the ui before, but need to change that). will jump into it again shortly.

I think the umbrel image has already been patched and merged yesterday! Thanks for looking into this though.