Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: derive devfee from config and calculate fee for miners #70

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: derive devfee from config and calculate fee for miners #70

wants to merge 6 commits into from

Conversation

owenashurst
Copy link

@owenashurst owenashurst commented Oct 20, 2024 •
edited
Loading

Just a little refactor to derive the DevFee from config instead of being hardcoded.

  • Removed unnecessary line breaks
  • Refactored out DevFee to be config driven
  • Added fee method to calculate what reward the miner should get after the devFee

@owenashurst owenashurst marked this pull request as draft October 20, 2024 16:55
@owenashurst owenashurst marked this pull request as ready for review October 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@owenashurst