Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add classes for plugin type #1457

Closed

Conversation

SventB
Copy link
Contributor

@SventB SventB commented Jan 5, 2024

Pull Request

Prerequisites

  • Changes have been tested on TYPO3 v11.5 LTS
  • Changes have been tested on TYPO3 v12.4 LTS
  • Changes have been tested on PHP 7.4
  • Changes have been tested on PHP 8.0
  • Changes have been tested on PHP 8.1
  • Changes have been tested on PHP 8.2
  • Changes have been checked for CGL compliance php-cs-fixer fix
  • CSS has been rebuilt (only if there are SCSS changes cd Build; npm ci; npm run build)

Description

It could be useful to know which plugin a frame contains. This pull requests adds this information (e.g. class "frame-type-list-indexedsearch_pi2") to the frame-div:

<div id="c149" class=" frame frame-default frame-type-list frame-type-list-indexedsearch_pi2 frame-layout-default frame-size-default frame-height-default frame-background-none frame-space-before-none frame-space-after-none frame-no-backgroundimage">

Steps to Validate

  1. Create a content element containing a plugin, e.g. plugin of EXT:indexed_search
  2. Check HTML code in FE

@benjaminkott
Copy link
Owner

@SventB list-type has just been deprecated and will be phased out, it´s recommended to use the CType instead. Moving forward we there will only be dedicated CType for everthing. I will close this pr for that reasoning. Please see the patch deprecating list-type for more information.

https://review.typo3.org/c/Packages/TYPO3.CMS/+/86253

@SventB SventB deleted the feature/frame-class-plugin-type branch October 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants