Fix non-fully specified URLs.

benjaminrich · Mar 22, 2020 · f9a8ee0 · f9a8ee0
1 parent 3805168
commit f9a8ee0
Show file tree

Hide file tree

Showing 4 changed files with 587 additions and 536 deletions.
diff --git a/.Rbuildignore b/.Rbuildignore
@@ -3,3 +3,4 @@
 ^_config.yml$
 ^cran-comments\.md$
 ^\.travis\.yml$
+^CRAN-RELEASE$
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,12 +1,16 @@
+# Version 1.2
+
 ## Test environments
 
-* Local Windows 10, R 3.6.2 (x86_64-w64-mingw32/x64)
-* Linux on travis-ci (release and devel)
+* Local:
+  - Windows 10, R 3.6.2 (x86_64-w64-mingw32/x64)
+* travis-ci:
+  - Ubuntu Linux 16.04.6 LTS (release and devel)
 * win-builder (release and devel)
 * R-hub builder (https://builder.r-hub.io)
-  - Platform:   Windows Server 2008 R2 SP1, R-devel, 32/64 bit
-  - Platform:   Ubuntu Linux 16.04 LTS, R-release, GCC
-  - Platform:   Fedora Linux, R-devel, clang, gfortran
+  - Windows Server 2008 R2 SP1, R-devel, 32/64 bit
+  - Ubuntu Linux 16.04 LTS, R-release, GCC
+  - Fedora Linux, R-devel, clang, gfortran
 
 ## R CMD check results
 
@@ -18,3 +22,22 @@
 * coveffectsplot: OK
 * yamlet: OK
 
+## Reviewer comments
+
+2020-03-22 Uwe Ligges:
+
+```
+Thanks, we see:
+
+
+Found the following (possibly) invalid file URI:
+URI: rmarkdown.rstudio.com/
+From: inst/doc/table1-examples.html
+
+Please use fully specified URLs starting with the protocol, e.g. https://.....
+
+Please fix and resubmit.
+```
+
+Fixed by adding `https://` prefix.
+
diff --git a/vignettes/table1-examples.Rmd b/vignettes/table1-examples.Rmd
@@ -318,7 +318,7 @@ this default style is not ugly, inevitably there will be a desire to customize
 the visual appearance of the table (fonts, colors, gridlines, etc).  The
 package provides a limited number of built-in options for changing the style,
 while further customization can be achieved in [R
-Markdown](rmarkdown.rstudio.com/) documents using CSS (see below).
+Markdown](https://rmarkdown.rstudio.com/) documents using CSS (see below).
 
 ### Using built-in styles
 
@@ -351,7 +351,7 @@ Multiple styles can be applied in combination by separating them with a space.
 ### Using custom CSS to control the table's appearance
 
 Further customization of the table appearance is only possible in [R
-Markdown](rmarkdown.rstudio.com/) documents, by using custom CSS which is
+Markdown](https://rmarkdown.rstudio.com/) documents, by using custom CSS which is
 specified in the document's YAML header. For examples, to include `style.css`
 in the output, the YAML header should contain the following: