Fix normalization; Is done inside boundary_value_function

bennibolm · Nov 30, 2023 · 28f221b · 28f221b
1 parent a3fdfc0
commit 28f221b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 12 deletions.
diff --git a/examples/structured_2d_dgsem/elixir_euler_double_mach.jl b/examples/structured_2d_dgsem/elixir_euler_double_mach.jl
@@ -83,8 +83,7 @@ end
     if x[1] < 1 / 6 # BoundaryConditionCharacteristic
         u_outer = Trixi.characteristic_boundary_value_function(initial_condition_double_mach_reflection,
                                                                u_inner,
-                                                               normal_direction /
-                                                               norm(normal_direction),
+                                                               normal_direction,
                                                                direction, x, t, equations)
 
     else # if x[1] >= 1 / 6 # boundary_condition_slip_wall

diff --git a/examples/structured_2d_dgsem/elixir_euler_double_mach_MCL.jl b/examples/structured_2d_dgsem/elixir_euler_double_mach_MCL.jl
@@ -83,8 +83,7 @@ end
     if x[1] < 1 / 6 # BoundaryConditionCharacteristic
         u_outer = Trixi.characteristic_boundary_value_function(initial_condition_double_mach_reflection,
                                                                u_inner,
-                                                               normal_direction /
-                                                               norm(normal_direction),
+                                                               normal_direction,
                                                                direction, x, t, equations)
 
     else # if x[1] >= 1 / 6 # boundary_condition_slip_wall

diff --git a/src/equations/equations.jl b/src/equations/equations.jl
@@ -226,9 +226,9 @@ end
                                                                        x, t,
                                                                        surface_flux_function,
                                                                        equations)
-    u_boundary = characteristic_boundary_value_function(boundary_condition.outer_boundary_value_function,
-                                                        u_inner, orientation_or_normal,
-                                                        direction, x, t, equations)
+    u_boundary = boundary_condition.boundary_value_function(boundary_condition.outer_boundary_value_function,
+                                                            u_inner, orientation_or_normal,
+                                                            direction, x, t, equations)
 
     # Calculate boundary flux
     if iseven(direction) # u_inner is "left" of boundary, u_boundary is "right" of boundary
@@ -248,9 +248,9 @@ end
                                                                        x, t,
                                                                        surface_flux_function,
                                                                        equations)
-    u_boundary = characteristic_boundary_value_function(boundary_condition.outer_boundary_value_function,
-                                                        u_inner, normal_direction, x, t,
-                                                        equations)
+    u_boundary = boundary_condition.boundary_value_function(boundary_condition.outer_boundary_value_function,
+                                                            u_inner, normal_direction, x, t,
+                                                            equations)
 
     # Calculate boundary flux
     flux = surface_flux_function(u_inner, u_boundary, normal_direction, equations)

diff --git a/src/solvers/dgsem_tree/dg_2d_subcell_limiters.jl b/src/solvers/dgsem_tree/dg_2d_subcell_limiters.jl
@@ -1889,8 +1889,7 @@ end
 
     u_outer = boundary_condition.boundary_value_function(boundary_condition.outer_boundary_value_function,
                                                          u_inner,
-                                                         normal_direction /
-                                                         norm(normal_direction),
+                                                         normal_direction,
                                                          direction, x, t, equations)
 
     return u_outer