Skip to content

Commit

Permalink
Enable test again. Disable solve()
Browse files Browse the repository at this point in the history
  • Loading branch information
bennibolm committed Dec 9, 2024
1 parent c7c7131 commit 91ae4d2
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 35 deletions.
8 changes: 4 additions & 4 deletions examples/t8code_2d_fv/elixir_advection_basic.jl
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ callbacks = CallbackSet(summary_callback, analysis_callback, alive_callback,
###############################################################################
# run the simulation

sol = solve(ode, CarpenterKennedy2N54(williamson_condition = false),
dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
save_everystep = false, callback = callbacks);
summary_callback()
# sol = solve(ode, CarpenterKennedy2N54(williamson_condition = false),
# dt = 1.0, # solve needs some value here but it will be overwritten by the stepsize_callback
# save_everystep = false, callback = callbacks);
# summary_callback()

GC.enable(true)
62 changes: 31 additions & 31 deletions test/test_mpi_t8code_fv_2d.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,37 +13,37 @@ const EXAMPLES_DIR = pkgdir(Trixi, "examples", "t8code_2d_fv")
# Run basic tests
@testset "Examples 2D" begin
# Linear scalar advection
# @trixi_testset "elixir_advection_basic.jl" begin
# @trixi_testset "first-order FV" begin
# @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_basic.jl"),
# order=1,
# l2=[0.08551397247817498],
# linf=[0.12087467695430498])
# # Ensure that we do not have excessive memory allocations
# # (e.g., from type instabilities)
# let
# t = sol.t[end]
# u_ode = sol.u[end]
# du_ode = similar(u_ode)
# @test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 1000
# end
# end
# @trixi_testset "second-order FV" begin
# @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_basic.jl"),
# l2=[0.008142380494734171],
# linf=[0.018687916234976898])
# # Ensure that we do not have excessive memory allocations
# # (e.g., from type instabilities)
# let
# t = sol.t[end]
# u_ode = sol.u[end]
# du_ode = similar(u_ode)
# @test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 1000
# end
# end
# # The extended reconstruction stencil is currently not mpi parallel.
# # The current version runs through but an error occurs on some rank.
# end
@trixi_testset "elixir_advection_basic.jl" begin
@trixi_testset "first-order FV" begin
@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_basic.jl"),
order=1,
l2=[0.08551397247817498],
linf=[0.12087467695430498])
# Ensure that we do not have excessive memory allocations
# (e.g., from type instabilities)
let
t = sol.t[end]
u_ode = sol.u[end]
du_ode = similar(u_ode)
@test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 1000
end
end
@trixi_testset "second-order FV" begin
@test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_basic.jl"),
l2=[0.008142380494734171],
linf=[0.018687916234976898])
# Ensure that we do not have excessive memory allocations
# (e.g., from type instabilities)
let
t = sol.t[end]
u_ode = sol.u[end]
du_ode = similar(u_ode)
@test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 1000
end
end
# The extended reconstruction stencil is currently not mpi parallel.
# The current version runs through but an error occurs on some rank.
end

@trixi_testset "elixir_advection_gauss.jl" begin
@trixi_testset "first-order FV" begin
Expand Down

0 comments on commit 91ae4d2

Please sign in to comment.