-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nonlinear positivity limiting for arbitrary variables #115
Support nonlinear positivity limiting for arbitrary variables #115
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I leave a single comment in this review.
Although you were able to set the limiting variable with
positivity_variables_nonlinear=(pressure,)
, the limiting was hard-coded due toNow, it is implemented for general variables (if the specific functions for initial/final check and the derivative of the variable
variable(u, equations, True())
have been defined):