Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for non nonconservative equations to subcell-limiting #116

Merged
merged 70 commits into from
Nov 2, 2023
Merged

Add support for non nonconservative equations to subcell-limiting #116

merged 70 commits into from
Nov 2, 2023

Conversation

amrueda
Copy link
Collaborator

@amrueda amrueda commented Oct 13, 2023

No description provided.

amrueda and others added 22 commits October 5, 2023 17:47
@amrueda
Added first (ugly) implementation of subcell limiting for non-conserv…
99c1782 
…ative systems

-> A working version of this implementation is added for the GLM-MHD system
-> The flux-differencing formula requires non-conservative terms of the
   form (local * symmetric)... I modified equations/ideal_glm_mhd_2d.jl and
   solvers/dgsem_tree/dg_2d.jl to make it work
-> In this first implementation, we only use the Powell term and
   deactivate the GLM term
@amrueda
Modified non-conservative fluxes to revert src/solvers/dgsem_tree/dg_…
67e379f 
…2d.jl back to its original state
@amrueda
Subcell limiting: Added the possibility to use multiple nonconservati…
12c6c1d 
…ve terms
@amrueda
Added some comments and improved formatting
7017914
@amrueda
Added expected results for MHD subcell limiting test
5119d97
@amrueda
Restored old Powell source term and created a new function name for t…
ad6177e 
…he modified Powell source term. This was needed due to incompatibility on non-conforming meshes.
@amrueda
Fixed bug
9158093
@amrueda
Fixed bug
3dcccc4
@amrueda
Moved new multiple-dispatch structs for to equations.jl
adb930e
@amrueda
Improved allocations
b0e3aad
@amrueda
Avoid double computation of local part of non-conservative flux
e0a3fdf
@amrueda
Improved subcell volume integral in y direction and formatting
86884e8
@amrueda @ranocha
Apply suggestions from code review
0d61cfd 
Co-authored-by: Hendrik Ranocha <[email protected]>
@amrueda
Added timers and corrected docstrings
b0caf8e
@amrueda
Improved formatting
6dae80a
@amrueda
Reduced testing time
0c2e24e
@amrueda
Merge branch 'subcell_limiting_noncons' into subcell_positivity_nonco…
ac792bb 
…nservative and fixed some conflicts
@amrueda
Deactivate bar states for subcell positivity MHD test
9c73f4c
@amrueda
The pressure positivity limiter works for MHD
4e6681c
@amrueda
MCL works again FOR CONSERVATIVE SYSTEMS
82c9a2f
@amrueda
Merge branch 'subcell-limiting' into subcell_positivity_nonconservative
834b481
@amrueda
Subcell limiting is working with StructuredMesh again
48bd943
@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited by amrueda
Loading

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@amrueda amrueda requested a review from bennibolm October 17, 2023 10:53
amrueda and others added 24 commits October 23, 2023 15:23
@amrueda
Unified pressure derivative functions for the 2D Euler equations
342bf60
@amrueda @bennibolm
Apply suggestions from code review
41dc2a1 
Co-authored-by: Benjamin Bolm <[email protected]>
@amrueda
Removed timers from MCL routines (not compatible with multi-threading)
f00ac01
@amrueda
Renamed flux_nonconservative_powell2 to flux_nonconservative_powell_l…
50be874 
…ocal_symmetric
@amrueda
Merge branch 'main' into subcell_limiting_noncons
e7d1b08
@amrueda @bennibolm
Increased maximum allowed allocation bound for subcell limiting simul…
c7c3ca0 
…ation

Co-authored-by: Benjamin Bolm <[email protected]>
@amrueda
Added explanatory comments about different non-conservative fluxes an…
120f9ba 
…d multiple dispatch
@amrueda
Changed variable name noncons_term to nonconservative_term
81d40e2
@amrueda @sloede
Update docstrin of flux_nonconservative_powell_local_symmetric
c7dd7f5 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda
Renamed function nnoncons as n_nonconservative_terms
7910993
@amrueda
format
3f9f0fe
@amrueda @sloede
Apply suggestions from code review
b6646ad 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda @bennibolm
Non-conservative subcell limiting cache only allocated for non-conser…
0eee721 
…vative equations

Co-authored-by: Benjamin Bolm <[email protected]>
@amrueda
Merge branch 'main' into subcell_limiting_noncons
df12f03
@DanielDoehring @sloede @jlchan
AMR for parabolic terms in 2D & 3D on TreeMeshes (trixi-framework#1629)
4d22141 
* Clean branch

* Un-Comment

* un-comment

* test coarsen

* remove redundancy

* Remove support for passive terms

* expand resize

* comments

* format

* Avoid code duplication

* Update src/callbacks_step/amr_dg1d.jl

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

* comment

* comment & format

* Try to increase coverage

* Slightly more expressive names

* Apply suggestions from code review

* add specifier for 1d

* Structs for resizing parabolic helpers

* check if mortars are present

* reuse `reinitialize_containers!`

* resize calls for parabolic helpers

* update analysis callbacks

* Velocities for compr euler

* Init container

* correct copy-paste error

* resize each dim

* add dispatch

* Add AMR for shear layer

* USe only amr shear layer

* first steps towards p4est parabolic amr

* Add tests

* remove plots

* Format

* remove redundant line

* platform independent tests

* No need for different flux_viscous comps after adding container_viscous to p4est

* Laplace 3d

* Longer times to allow converage to hit coarsen!

* Increase testing of Laplace 3D

* Add tests for velocities

* remove comment

* Add comments

* Remove some specializations

* Add comments

* Use tuple for outer, fixed size datastruct for internal quantities

* Format

* Add comments

* Update examples/tree_2d_dgsem/elixir_navierstokes_shearlayer_amr.jl

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

* Update src/Trixi.jl

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

* Move velocity into elixir

* remove tests

* Remove deprecated comments

* Add news

---------

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Jesse Chan <[email protected]>
@amrueda
Merge branch 'subcell-limiting' into subcell_positivity_nonconservative
a23b6b1
@amrueda
Merge branch 'subcell_limiting_noncons' into subcell_positivity_nonco…
ee21f0a 
…nservative
@sloede
Set version to v0.5.47
4744105
@sloede
Set development version v0.5.48-pre
dc0dc1d
@amrueda
Merge branch 'subcell-limiting' into subcell_positivity_nonconservative
6f43419
@ranocha
format with new version of JuliaFormatter (trixi-framework#1696)
3e9ee80
@ranocha
format test directory (trixi-framework#1688)
0f49e5b 
* format test

* move D_SBP = ... outside of at-test_trixi_include

* fix definition of SBP operators in tests (global)

* do not indent all test files

* fix typo

* check formatting of test
@amrueda @ranocha
@bennibolm @sloede
Implement subcell limiting for non-conservative systems (trixi-framew…
61c33b0 
…ork#1670)

Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Benjamin Bolm <[email protected]>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda
Merge branch 'main' into subcell_positivity_nonconservative
3e81bbb
@amrueda @bennibolm
Add memory allocation test
30b33fd 
Co-authored-by: Benjamin Bolm <[email protected]>
@bennibolm bennibolm merged commit bd781ec into bennibolm:subcell-limiting Nov 2, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennibolm bennibolm bennibolm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amrueda @bennibolm @ranocha @sloede @DanielDoehring