Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main: Remove dispatching for mesh types #128

Merged
merged 30 commits into from
May 24, 2024
Merged

Merge main: Remove dispatching for mesh types #128

merged 30 commits into from
May 24, 2024

Conversation

bennibolm
Copy link
Owner

No description provided.

bennibolm and others added 23 commits May 14, 2024 13:35
@bennibolm
Add structured mesh support
b1cdce7
@bennibolm
Fix non-periodic computation of bounds
c1af151
@bennibolm
Use local limiting and nonperiodic domain in source terms elixir
2ddd78a
@bennibolm
Use local limiting in free stream elixir
98c2144
@bennibolm
Remove not needed lines
ccb833e
@bennibolm
Merge branch 'main' into bb/subcell-limiting-structuredmesh
18dc2e1
@bennibolm
Remove P4estMesh
003d43c
@bennibolm
Add non-periodic tests with local bounds
e918af0
@bennibolm
fmt
5a7b8ce
@bennibolm
Fix test
632a934
@bennibolm
Use get_inverse_jacobian instead of dispatching all routines
b26a8f2
@bennibolm
Simplify perform_idp_correction!
8c5047a
@bennibolm
Revert stuff
80dd9bf
@bennibolm
Remove free stream elixir
7102fbd
@bennibolm
Merge branch 'main' into bb/subcell-limiting-structuredmesh
51c9fe5
@bennibolm
Merge branch 'main' into bb/subcell-limiting-structuredmesh
0279dd0
@bennibolm
Use sedov blast instead of source term setup; add news
dc6d554
@bennibolm
Update dispatching for mesh types
ee86e27
@bennibolm
Merge branch 'main' into bb/subcell-limiting-structuredmesh
793ebc2
@bennibolm
Merge branch 'main' into bb/subcell-limiting-structuredmesh
db135df
@bennibolm
Remove dispatching for mesh types
f3f91bf
@bennibolm
Move new sedov tests within the test file
2e6b0a8
@bennibolm
Move new tests within test file
7f8f58d
@github-actions GitHub Actions
Copy link

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

bennibolm and others added 6 commits May 23, 2024 15:18
@bennibolm
Adapt dispatching
40f475c
@bennibolm
Fix typo
12400ee
@bennibolm
Merge branch 'bb/subcell-limiting-structuredmesh' into subcell-limiti…
a271a1c 
…ng-mergemain
@bennibolm
Remove not-needed parameter
a6c4ff0
@bennibolm
Add subcell limiting support for StructuredMesh (trixi-framework#1946)
2da0863 
* Add structured mesh support

* Fix non-periodic computation of bounds

* Use local limiting and nonperiodic domain in source terms elixir

* Use local limiting in free stream elixir

* Remove not needed lines

* Remove P4estMesh

* Add non-periodic tests with local bounds

* fmt

* Fix test

* Use `get_inverse_jacobian` instead of dispatching all routines

* Simplify `perform_idp_correction!`

* Revert stuff

* Remove free stream elixir

* Use sedov blast instead of source term setup; add news

* Update dispatching for mesh types

* Move new tests within test file

* Adapt dispatching

* Fix typo

* Remove not-needed parameters
@bennibolm
Merge branch 'main' into subcell-limiting-mergemain
488b794
@bennibolm bennibolm changed the title Remove dispatching for mesh types Merge main: Remove dispatching for mesh types May 24, 2024
@bennibolm bennibolm merged commit 8562942 into subcell-limiting May 24, 2024
7 of 33 checks passed
@bennibolm bennibolm deleted the subcell-limiting-mergemain branch May 24, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bennibolm