Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Add Mypy Static Type Checking to SDK & Pull latest bentobox-engine image as build cache #61

Merged
merged 27 commits into from
Feb 20, 2021
Merged

Add Mypy Static Type Checking to SDK & Pull latest bentobox-engine image as build cache #61

merged 27 commits into from
Feb 20, 2021

Commits on Feb 18, 2021

  1. feat(build): Add mypy to project makefile to lint types when linting SDK

    @mrzzy
    mrzzy committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    471a3c1 View commit details
    Browse the repository at this point in the history

  2. build(sdk): Update requirements-dev.txt to include mypy

    @mrzzy
    mrzzy committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    e6af0aa View commit details
    Browse the repository at this point in the history

  3. refactor(sdk): Fix or ignore errors flagged by mypy.

    @mrzzy
    mrzzy committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    b6cf099 View commit details
    Browse the repository at this point in the history

  4. repo: Add secrets, end of file, trailing whitespac, merge confict and… 

    … secrets pre commit checks
    @mrzzy
    mrzzy committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    7be011d View commit details
    Browse the repository at this point in the history

  5. refactor(ci/cd): Replace docker image caching in favor of just pullin… 

    …g the previous docker image
    @mrzzy
    mrzzy committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    e8a2fa4 View commit details
    Browse the repository at this point in the history

  6. feat(cd): Also push bentobox-engine to the latest tag on publish-engi… 

    …ne job
    @mrzzy
    mrzzy committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    91959f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. refactor(build): Execute mypy standalone instead of via python -m

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    d6ead91 View commit details
    Browse the repository at this point in the history

  2. fix(ci): Fix typos causing pull image for cache step to fail, tempora… 

    …ry run CD in PR for testing
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    cf093b8 View commit details
    Browse the repository at this point in the history

  3. fix(sdk): Fix failing mypy due by removing unneeded typing-protobuf p… 

    …ackage
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    787a5fb View commit details
    Browse the repository at this point in the history

  4. chore(sdk): Remove uneeded type: ignores and clean up types

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    1dd6339 View commit details
    Browse the repository at this point in the history

  5. fix(build): Fix project makefile's lint-sdk failing due to mypy missi… 

    …ng type annoatations for protobuf bindings
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    46c94f4 View commit details
    Browse the repository at this point in the history

  6. fix(build): Fix missing cache metadata when required to use pulled im… 

    …ages as cache
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    6ce094a View commit details
    Browse the repository at this point in the history

  7. fix(ci): Fix missing protoc required to run make lint-sdk

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    87f532d View commit details
    Browse the repository at this point in the history

  8. refactor(ci): Run lint-sdk as a seperate job from build-test-sdk 

    Simplifies as we do not need to support linting on all OSes. linting
only looks for the problems in the codebase which is OS-independent, so
linting on one OS should be sufficient
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    e0dca62 View commit details
    Browse the repository at this point in the history

  9. fix(ci): Fix build-test-sdk still install protoc and protoc-gen-mypy … 

    …not in PATH
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    c868527 View commit details
    Browse the repository at this point in the history

  10. fix(cd): Fix missing docker tag bentobox-engine image as latest

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    533dd9d View commit details
    Browse the repository at this point in the history

  11. chore(ci): Add name to to lint-sdk CI job

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    ab6914a View commit details
    Browse the repository at this point in the history

  12. fix(ci): Move GITHUB_PATH setting to previous action in job as PATH i… 

    …s only updated for subsequent jobs
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    0c62daa View commit details
    Browse the repository at this point in the history

  13. refactor(sdk): Bump numpy to 1.20.1 to get builtin type annotations

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    95462e1 View commit details
    Browse the repository at this point in the history

  14. fix(ci/cd): Use docker buildkit as docker cache from pulled images on… 

    …ly works for buildkit images
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    bac8f8f View commit details
    Browse the repository at this point in the history

  15. Revert "refactor(sdk): Bump numpy to 1.20.1 to get builtin type annot… 

    …ations"

This reverts commit 95462e1.
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    327a6eb View commit details
    Browse the repository at this point in the history

  16. fix(ci): Use setup-python to setup python in lint-sdk instead of usin… 

    …g runner python
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    b64bf08 View commit details
    Browse the repository at this point in the history

  17. feat(ci/cd): Add cache-from flag to use cached latest image as build … 

    …cache
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    c2c6fa4 View commit details
    Browse the repository at this point in the history

  18. fix(build): Fix mypy unable to find generated stubs for Python protob… 

    …uf bindings
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    ba07c53 View commit details
    Browse the repository at this point in the history

  19. fix(build): Fix mypy unable to find generated stubs for Python protob… 

    …uf bindings by installing sdk before lint
    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    7a684e0 View commit details
    Browse the repository at this point in the history

  20. fix(build): Fix missing dep dependencies when using make install-sdk

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    157b909 View commit details
    Browse the repository at this point in the history

  21. chore(cd): Remove temporary on: section used for testing CD pipeline

    @mrzzy
    mrzzy committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    7ae6c4d View commit details
    Browse the repository at this point in the history