Fix pagination in getAllCountsByColumn #123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
I realize now getAllCountsByColumn had flawed logic; it was trying to get the top N rows, but also trying to simultaneously get data for visitors and views which doesn't work because that needs 2x the rows, and the
count
properties might not return in the same order either.So instead this makes two queries:
First, queries the column by visitor count. This first query determines the order (so the rows are sorted by visitor count, not view count).
Then, make another query by view count, using a
WHERE $column IN ($columnVal1, $columnVal1, ... $columnVal1)
clause from the results of the first query.This is slower of course, but it seems unavoidable the way Analytics Engine works.