Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade latest Remix and enable all future flags #130

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

benvinegar
Copy link
Owner

@benvinegar benvinegar commented Dec 19, 2024

Upgrades to Remix v2.15 and enables remaining future flags:

  • v3_routeConfig
  • v3_lazyRouteDiscovery
  • v3_singleFetch

This is to prepare Counterscale for migrating to React Router v7 in the future.

NOTE: This has the unfortunate side effect of causing a bunch of React Router Future Flag Warning output in tests. This is caused by remix-run/remix#10216.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (d1485b1) to head (f079c52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/root.tsx 0.00% 2 Missing ⚠️
app/routes.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   78.55%   78.49%   -0.07%     
==========================================
  Files          33       34       +1     
  Lines        2486     2488       +2     
  Branches      265      266       +1     
==========================================
  Hits         1953     1953              
- Misses        525      526       +1     
- Partials        8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit b88fca8 into main Dec 19, 2024
3 checks passed
@benvinegar benvinegar deleted the latest-remix-v2 branch December 19, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant