-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate tracker build + tests w/ Vite, Turborepo, & Playwright [WIP] #132
Open
benvinegar
wants to merge
20
commits into
main
Choose a base branch
from
turborepo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
force-pushed
the
turborepo
branch
2 times, most recently
from
December 20, 2024 04:20
51f2840
to
3f3aacb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 78.49% 84.76% +6.26%
==========================================
Files 34 33 -1
Lines 2488 2304 -184
Branches 266 265 -1
==========================================
Hits 1953 1953
+ Misses 526 343 -183
+ Partials 9 8 -1 ☔ View full report in Codecov by Sentry. |
benvinegar
force-pushed
the
turborepo
branch
from
December 20, 2024 14:36
adfa51c
to
6b961e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very large change and is currently in WIP
Up until this point,
tracker.js
has been a static file sitting in the/public
Remix directory.I want to start modifying it, but to make sure I do not cause regressions, I need to introduce browser-level integration tests that assert its current behavior first.
This change does the following:
workspaces/server
workspaces/tracker
that buildsdist/tracker.js
workspaces/server
copies thisdist/tracker.js
into its public directoryworkspaces/tracker
, and adds a simple test that runs a web server that serves an HTML document that loadsdist/tracker.js
and asserts makes a page view is trackedturbo lint
,turbo typecheck
, etc. which invokes the appropriate command on each workspaceFuture considerations:
tracker.js
to be rewritten in TypeScript, since there is a full Vite build.npm
(e.g. under@counterscale/tracker
) and be installed that way (though it needs some work to expose a JS API first).Still left to do: