-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding browser version tracking #135
Conversation
@S-Makrod First, thanks for contributing this. But we should connect before you tackle some of these, because I don't know that it's desirable to collect and display browser version. For a number of reasons:
That being said I like how you made this as a detail item when you click into Chrome. I'll have to think about it. But there is a Open to discussion though from users. EDIT: It appears Plausible does record and report browser version. That makes me feel better/more amenable to this change. |
@benvinegar Thanks for the feedback. No worries; in hindsight, I should have verified with you to check if this is a route you want to go down. I just assumed that since the issue was open, it was okay for me to tackle. Let me know if anything changes. I may take a look at #119 in the coming days, as you mentioned that it is better since it requires less detail. |
I think it's still worth exploring. Here's my asks if you want to take this further:
Also, open to community input here. |
@benvinegar I've added your suggested changes. One thing to note is that I placed the browser version masking function in |
Yeah, ofc. Things like that can always change easily. The biggest challenge now is that I merged a pretty big refactor (#132) which moves paths and other stuff around. You'll have to rebase and it will be messy. I can also lend a hand. |
79f9296
to
5e47e3b
Compare
@benvinegar rebase is complete |
Description
Adds tracking of browser versions to Counterscale. The implementation updates the dashboard so that when a browser name is specified in the search filters we replace
BrowserCard
withBrowserVersionCard
to list browser versions.Main Changes
Example deployed at https://dc458fa5.counterscale-7bi.pages.dev/dashboard?site=counterscale-dev&interval=today&browserName=Chrome&browserVersion=131.0.0.0
Images
Originally we see the dashboard:
After clicking on
Chrome
, we replaceBrowserCard
withBrowserVersionCard
:Note
I had an issue with testing
dashboard.test.tsx
where calls toasync waitFor(...)
would timeout. I resolved this on my end by adding a timeout of 5 seconds. These changes are not pushed since I believe it is just an issue with my machine. I thought I should leave a note in case testing fails for that suite.Example of timeout call:
Issue
This closes #120