Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly reflect results in local timezone #16

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Properly reflect results in local timezone #16

merged 4 commits into from
Jan 20, 2024

Conversation

benvinegar
Copy link
Owner

Fixes #6

  • Local timezone is extracted from cf property and passed as context to loader
  • Results by day now use local timezone to determine start of day
  • Internally, dates are now consistently represented in UTC, but on display converted to local time (i.e. in chart)
  • Tests now set timezone (via env variables) and incorporate timezone in results

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (5fbb7e6) 64.61% compared to head (6ac6d17) 64.34%.

Files Patch % Lines
app/components/TimeSeriesChart.tsx 0.00% 18 Missing ⚠️
app/routes/dashboard.tsx 0.00% 3 Missing ⚠️
server.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   64.61%   64.34%   -0.28%     
==========================================
  Files          17       17              
  Lines        1611     1652      +41     
  Branches       88       89       +1     
==========================================
+ Hits         1041     1063      +22     
- Misses        564      583      +19     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit 9daf0c0 into main Jan 20, 2024
1 of 3 checks passed
@benvinegar benvinegar deleted the fix-tzs branch January 20, 2024 14:59
benvinegar added a commit that referenced this pull request Dec 20, 2024
* Fix hourly timezone data

* Results by day now use local tz to determine start of day

* Fix lint errors

* Fix timestamp assertions to reflect fixed timezone code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart data points are not in local timezone
1 participant