Fix exception thrown in dashboard route test #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception was caused because if you do not send a valid country code, the country name formatter will explode. The mock test data was sending "Canada", "United States", etc. when it should have been sending "CA", "US', etc.
This patch just addresses the input data so that the tests run (and adds some assertions, which should have been there from the beginning). The fundamental problem is still there: the Dashboard will choke if it's fed non-country code values, which seems really brittle. On the plus side the country codes are coming from Cloudflare's request object (vs arbitrary user data).
Fixes #21