Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for dashboard loader #25

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Add test for dashboard loader #25

merged 4 commits into from
Feb 2, 2024

Conversation

benvinegar
Copy link
Owner

Trying to improve test coverage. Needs to cover more failure cases.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bc4408e) 67.84% compared to head (4cbb16b) 71.68%.

Files Patch % Lines
app/analytics/query.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   67.84%   71.68%   +3.83%     
==========================================
  Files          18       18              
  Lines        1695     1695              
  Branches       98      110      +12     
==========================================
+ Hits         1150     1215      +65     
+ Misses        539      474      -65     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benvinegar benvinegar merged commit aaca36b into main Feb 2, 2024
3 checks passed
@benvinegar benvinegar deleted the dashboard-loader-test branch February 2, 2024 05:43
benvinegar added a commit that referenced this pull request Dec 20, 2024
* Add test for dashboard loader

* Fix mocked response value for getViewsGroupedByInterval

* Fix lint error on @ts-expect-error

* Add assertion for lodaer output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant