Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for query, remove type assertions and switch to inference where possible #26

Merged
merged 1 commit into from
Feb 3, 2024

Add types for query, remove type assertions and switch to inference w…

888df60
Select commit
Loading
Failed to load commit list.
Merged

Add types for query, remove type assertions and switch to inference where possible #26

Add types for query, remove type assertions and switch to inference w…
888df60
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 3, 2024 in 0s

71.21% (target 0.00%)

View this Pull Request on Codecov

71.21% (target 0.00%)

Details

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (aaca36b) 71.68% compared to head (888df60) 71.21%.

Files Patch % Lines
app/analytics/query.ts 68.91% 39 Missing and 7 partials ⚠️
app/lib/utils.ts 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   71.68%   71.21%   -0.47%     
==========================================
  Files          18       18              
  Lines        1695     1831     +136     
  Branches      110      124      +14     
==========================================
+ Hits         1215     1304      +89     
- Misses        474      514      +40     
- Partials        6       13       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.